[xwiki-contrib/application-releasenotes] a9d6e4: RN-111: The application pages do not declare the r...
Branch: refs/heads/RN-111 Home: https://github.com/xwiki-contrib/application-releasenotes Commit: a9d6e417b3c2c504da1f21a8a7a5baed02cfa38b https://github.com/xwiki-contrib/application-releasenotes/commit/a9d6e417b3c... Author: Vincent Massol <[email protected]> Date: 2026-09-06 (Sun, 06 Sep 2026) Changed paths: M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ApplicationsPanelEntry.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerFlow.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerGrid.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerList.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerSimple.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/GetChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HTML5Video.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNoteClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfig.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfigClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Report.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebHome.xml A application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebPreferences.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/RequiredRightsTest.java Log Message: ----------- RN-111: The application pages do not declare the rights they require * Declare and enforce required rights on 29 of the application's pages, at the level XWiki's own required-rights analyzer computes for each of them: script on the 21 script-bearing pages, wiki_admin on Code.ApplicationsPanelEntry for its wiki-scoped UI extension and on Code.Translations for its wiki-scoped translation bundle, and nothing at all on the 6 pages that need nothing, which is the setting that stops a later editor from introducing script into them. Code.MigrationFrom1x already enforced wiki_admin and keeps it. * Add ReleaseNotes.Code.WebPreferences, restricting edit and delete on the code space to XWiki.XWikiAdminGroup. Nested spaces inherit it, so it covers ReleaseNotes.Code.Change too. view is deliberately absent: an allow rule is exclusive, so listing it would deny view to everyone outside the group. * Leave ReleaseNotes.WebHome, ReleaseNotes.Data.WebHome, Code.HomeReleaseNotes and Code.ReleaseNoteTemplate not enforcing. Enforcement caps the rights of whatever a page includes and is forced onto every document an enforcing page's script saves, so enforcing the release note creation chain either breaks the Velocity the template copies onto a new release note or makes script right a condition of editing one, against RN-30. RN-112 covers taking the Velocity out of the template so that these four can enforce as well. * Add RequiredRightsTest, asserting the expected level page by page so that adding a page to the application forces a decision about what it requires, and asserting the code space's rights object. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications