[xwiki/xwiki-platform] 956979: XWIKI-25199: PasswordClass related error when logi...
Branch: refs/heads/XWIKI-25199 Home: https://github.com/xwiki/xwiki-platform Commit: 95697983ff7dc1ba341b8b391236ea1833414c44 https://github.com/xwiki/xwiki-platform/commit/95697983ff7dc1ba341b8b391236e... Author: Simon Urli <[email protected]> Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/PasswordClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/migration/R180100000XWIKI23827DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/migration/R180800000XWIKI24357DataMigration.java A xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/migration/R180900000XWIKI25199DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/META-INF/components.txt M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/BaseCollectionTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/PasswordClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/migration/R180100000XWIKI23827DataMigrationTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/migration/R180800000XWIKI24357DataMigrationTest.java A xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/migration/R180900000XWIKI25199DataMigrationTest.java Log Message: ----------- XWIKI-25199: PasswordClass related error when login with Admin after an instance upgrade * Flush the document cache at the end of R180100000XWIKI23827DataMigration and R180800000XWIKI24357DataMigration: a user profile cached before them (e.g. by R160300000XWIKI17243DataMigration) and saved after them (e.g. by XClassMigratorListener when the XWikiUsers class gets new fields) was putting back the legacy StringProperty password, overriding the migrated one * Add R180900000XWIKI25199DataMigration to execute again both migrations, to fix the passwords already put back in their legacy storage * Log the actual legacy algorithm (e.g. SHA-512) instead of XWikiLegacy for passwords not re-encoded yet, and log the reference of the property holding the password instead of the class one * Provide PasswordClass#arePasswordsMatching(String, String, EntityReference) to give the location of the password * Stop logging twice the usage of a deprecated algorithm when computing a hash * Add tests Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: 68b9b3c025aae7bd6551bc990a8a336e800f2aca https://github.com/xwiki/xwiki-platform/commit/68b9b3c025aae7bd6551bc990a8a3... Author: Simon Urli <[email protected]> Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/PasswordClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/BaseCollectionTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/PasswordClassTest.java Log Message: ----------- XWIKI-25199: PasswordClass related error when login with Admin after an instance upgrade * Remove PasswordClass#arePasswordsMatching(String, String, EntityReference): the location of the password is only used for logging, it shouldn't be exposed in an API Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Commit: d787b0f1a29de93a8c32e54af1678a33abb83160 https://github.com/xwiki/xwiki-platform/commit/d787b0f1a29de93a8c32e54af1678... Author: Simon Urli <[email protected]> Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/migration/R180100000XWIKI23827DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/migration/R180800000XWIKI24357DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/migration/R180100000XWIKI23827DataMigrationTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/migration/R180800000XWIKI24357DataMigrationTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/migration/R180900000XWIKI25199DataMigrationTest.java Log Message: ----------- XWIKI-25199: PasswordClass related error when login with Admin after an instance upgrade * Remove the explicit document cache flush from R180100000XWIKI23827DataMigration and R180800000XWIKI24357DataMigration: it's now done for every migration by AbstractHibernateDataMigration (XWIKI-25203) * Mock the XWiki context in R180900000XWIKI25199DataMigrationTest, now needed by AbstractHibernateDataMigration#migrate Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/d677fa34b197...d787b0f1a29d To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications