[xwiki-contrib/application-releasenotes] 384803: RN-94: The release note body strings are hardcoded...
Branch: refs/heads/master Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 384803b977fe17785e402f0bdba30ef54b3b3ca9 https://github.com/xwiki-contrib/application-releasenotes/commit/384803b977f... Author: Vincent Massol <[email protected]> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M application-releasenotes-ui/pom.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseNotes.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/MigrationFrom1x.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Data/WebHome.xml M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/AddChangePageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/ChangeSheetPageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/DisplayChangesMacroPageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/ReleaseNotesChangesMacroPageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/SpaceNameIndependencePageTest.java Log Message: ----------- RN-94: The release note body strings are hardcoded English instead of going through the translation bundle * Add to ReleaseNotes.Code.Translations a key for every user-visible string left in the application, and render them with the {{translation}} macro in wiki markup, and with $services.localization.render escaped for the target in the HTML the forms are built from. * Give every XClass field its label key and every static list value its value key, so that the object editor, the sheets and the Live Data of the home page name a property the same way. * Label the fields of the change and contributors sheets with the translated pretty name of the class field rather than with a key of the sheet's own, which also ends the wording drift between the form and the class ("Summary" against "Short Description", "Extra Description (optional)" against "Additional Description (Optional)", "Contributors (one per line)" against "Contributors"). * Give the three audience sections of a release note their own keys rather than one key per repeated English string, so that translating one section does not decide the wording of the two others. * Move the "one per line" the contributors label carried to a hint on the field itself. * Reword the failure of the release note creation form: it now names the version and links the release note that already exists. * Declare the runtime dependency on the {{translation}} macro, register that macro in the page tests that render a page using it, and hold the change edit form to the labels of its class fields. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: f34121ccebf2e1490a50c33cf91b202a63b41adf https://github.com/xwiki-contrib/application-releasenotes/commit/f34121ccebf... Author: Vincent Massol <[email protected]> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M application-releasenotes-ui/pom.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseNotes.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/MigrationFrom1x.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Data/WebHome.xml M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/AddChangePageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/ChangeSheetPageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/DisplayChangesMacroPageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/ReleaseNotesChangesMacroPageTest.java M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/SpaceNameIndependencePageTest.java Log Message: ----------- Merge pull request #35 from xwiki-contrib/RN-94 RN-94: The release note body strings are hardcoded English instead of going through the translation bundle Compare: https://github.com/xwiki-contrib/application-releasenotes/compare/708d845e42... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications