[xwiki/xwiki-dev-llm] ee0903: [Misc] Record which assertion style XWiki wants in...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: ee09038859ba6316fa1e24f26366bbe36dc5f8d2 https://github.com/xwiki/xwiki-dev-llm/commit/ee09038859ba6316fa1e24f26366bb... Author: Simon Urli <[email protected]> Date: 2026-10-01 (Thu, 01 Oct 2026) Changed paths: M xwiki/okf/testing/strategy.md M xwiki/skills/xwiki-convert-tests/SKILL.md Log Message: ----------- [Misc] Record which assertion style XWiki wants in a test * Add the assertion rule to okf/testing/strategy.md: the JUnit 5 assertion where one fits, Hamcrest assertThat where JUnit 5 has no matcher or reports nothing useful. assertTrue(content.contains(x)) fails with "expected: <true> but was: <false>" and never shows the content, which is exactly the case the dev wiki's Java unit testing best practices call for assertThat. * Guard the Hamcrest to JUnit 5 table in xwiki-convert-tests against being read as a blanket instruction. Its four rows are the matchers that do have a good JUnit 5 equivalent; converting containsString or hasItem the same way is the regression the new rule exists to prevent. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: cbff4e9ccf3de6d24a8c9d8e9654ab6ad078c163 https://github.com/xwiki/xwiki-dev-llm/commit/cbff4e9ccf3de6d24a8c9d8e9654ab... Author: Vincent Massol <[email protected]> Date: 2026-10-06 (Tue, 06 Oct 2026) Changed paths: M xwiki/okf/testing/strategy.md M xwiki/skills/xwiki-convert-tests/SKILL.md Log Message: ----------- Merge pull request #186 from xwiki/testing-assertthat-convention [Misc] Record which assertion style XWiki wants in a test Compare: https://github.com/xwiki/xwiki-dev-llm/compare/be35b47aaeea...cbff4e9ccf3d To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications
participants (1)
-
XWiki Notifications