Branch: refs/heads/XWIKI-22931 Home: https://github.com/xwiki/xwiki-platform Commit: 34909a083d40c3c59389c983bf808bb71dd5fe93 https://github.com/xwiki/xwiki-platform/commit/34909a083d40c3c59389c983bf808... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix XWikiDocument#copyAttachment to actually perform a real clone including the copy of the content * Introduce a XWikiAttachment#cloneWithActualContent to clone and copy the content * Introduce a XWikiAttachmentContent#clone(boolean) that allows to decide to skip or not copying the content WIP: right now tests are passing but it shows a regression in logs when running PageTemplatesIT, probably due to the ownerDocument of XWikiAttachmnentContent in clone method Commit: 231954b3d693526a63a19a2294964886bfa83742 https://github.com/xwiki/xwiki-platform/commit/231954b3d693526a63a19a2294964... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/test/java/org/xwiki/store/legacy/store/internal/FilesystemAttachmentVersioningStoreTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Get rid of ownerDocument in XWikiAttachmentContent * Properly override new clone method in extended classes * Set the attachment document in XWikiDocument#setAttachment WIP: this still shows a regression in PageTemplatesIT with a stacktrace about a missing attachment. Commit: c3bd9a7c173056a85084530efdae9de389bf53c6 https://github.com/xwiki/xwiki-platform/commit/c3bd9a7c173056a85084530efdae9... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Small improvments but still having bad stack trace when trying to create page from template related to Solr Commit: 586c18a58b5d015802038e841023f53dc336439e https://github.com/xwiki/xwiki-platform/commit/586c18a58b5d015802038e841023f... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Properly load the file content before cloning it WIP: there's still a problem with the template UC Commit: 0f0cb41a161cb91551e181767929a6eb1b8d634c https://github.com/xwiki/xwiki-platform/commit/0f0cb41a161cb91551e181767929a... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix override Commit: ad8cf6bfec2d4b6961d5522a686350dee6c2af2b https://github.com/xwiki/xwiki-platform/commit/ad8cf6bfec2d4b6961d5522a68635... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix since Commit: beb50b3c5b5405890a9a5e8da7d16a1a63b2bc2f https://github.com/xwiki/xwiki-platform/commit/beb50b3c5b5405890a9a5e8da7d16... Author: Simon Urli <[email protected]> Date: 2026-01-05 (Mon, 05 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/test/MockitoOldcore.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Ensure that the test is covered Compare: https://github.com/xwiki/xwiki-platform/compare/021e2ac561bc...beb50b3c5b54 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications