[xwiki/xwiki-commons] aec822: [Misc] Fix various SonarQube issues (#1942)
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: aec82234bacb573b5bb29bb9ade45c84450960bb https://github.com/xwiki/xwiki-commons/commit/aec82234bacb573b5bb29bb9ade45c... Author: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Date: 2026-09-02 (Wed, 02 Sep 2026) Changed paths: M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/test/java/org/xwiki/component/guice/GuiceCompatibilityTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/DefaultExtensionSerializer.java M xwiki-commons-core/xwiki-commons-legacy/xwiki-commons-legacy-classloader/xwiki-commons-legacy-classloader-api/src/main/java/org/xwiki/classloader/internal/ResourceLoader.java M xwiki-commons-tools/xwiki-commons-tool-extension-plugin/src/main/java/org/xwiki/tool/extension/util/ExtensionMojoHelper.java Log Message: ----------- [Misc] Fix various SonarQube issues (#1942) * [Misc] Fix various SonarQube issues * java:S2093 use a try-with-resources where the finally really closes the stream * java:S3012 copy the remaining arguments with a bulk operation * java:S1171 replace the instance initializer with a constructor * java:S119 rename a type parameter that was named "String" * java:S1186 document why two method bodies are empty Co-Authored-By: Vincent Massol <[email protected]> Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ * [Misc] Drop two SonarQube fixes that change behaviour or readability * java:S2093 InfinispanCacheFactory: IOUtils.closeQuietly() deliberately swallows a close failure while try-with-resources surfaces it, so the conversion is not behaviour-preserving * java:S3012 LogUtils: the loop appends a suffix of the array, and every bulk replacement needs a guard that reads worse than the loop it replaces Co-Authored-By: Vincent Massol <[email protected]> Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015Hg3cGVDYpa9k8oLnt5azJ --------- Co-authored-by: Vincent Massol <[email protected]> Co-authored-by: Claude Opus 5 <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications
participants (1)
-
XWiki Notifications