Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: bdc047c5d1588eb3053bd12f75308b1a787c4c37 https://github.com/xwiki/xwiki-platform/commit/bdc047c5d1588eb3053bd12f75308... Author: LucasC <[email protected]> Date: 2025-06-05 (Thu, 05 Jun 2025) Changed paths: M xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/ClassEditSheet.xml M xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Content.xml M xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Title.xml M xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Translations.xml M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/edit.less M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/wikieditor/wikibits.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/edit/editableProperty.js Log Message: ----------- XWIKI-20996: AWM entry edit forms don't have labels. (#3584) * Added a label to the editable properties in edit mode. * Fixed the lack of IDs on a couple 'hard coded' fields * Added localized and escaped aria labels for both the title and content fields. * Added comments in ClassEditSheet * Extended the input selector in _enhanceFieldDefaultValue so that the labelling would also work on select (eg. fieldType = StaticList) * Set an aria-label on default value fields, equal to the title. We don't care about the existing state, this label is always the same for all fields. * Added a translated label on the field hint/prettyName inputs in class edition mode. * Added the `for` attribute on the label even in view mode, so that the inline edition input is properly labelled. * Updated the ID of the content textarea. The only style left that relied on this was unneeded (same property set by another style...). Moreover, the functionality did not suffer when changing this. This allows to use the ID to label the textarea instead of relying on an aria-label. * Used a proper label instead of aria-label on the Title input. * Removed the inline label association when the input is removed. * Updated the content and title fields displays to use the object no. * Updated the text-editor to support the new markup of the textarea. * Added a UUID to the backup ID added for editableProperties. * Added a check for non-secured environments Co-authored-by: Michael Hamann <[email protected]> Co-authored-by: Marius Dumitru Florea <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications