Branch: refs/heads/sonarqube-fixes Home: https://github.com/xwiki/xwiki-commons Commit: a19eb1ca9dc0765dc0131520a8f2363c11fdd15d https://github.com/xwiki/xwiki-commons/commit/a19eb1ca9dc0765dc0131520a8f236... Author: Vincent Massol <[email protected]> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-cipher/src/test/java/org/xwiki/crypto/cipher/internal/symmetric/factory/AbstractSymmetricCipherFactoryTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-pkix/src/test/java/org/xwiki/crypto/signer/internal/cms/DefaultCMSSignedDataTest.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/test/java/org/xwiki/filter/internal/AbstractFilterDescriptorManagerTest.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/test/Utils.java Log Message: ----------- [Misc] Remove useless assignments to local variables (SonarQube java:S1854) * Dead stores reported by SonarCloud; side-effecting calls kept as plain statements. Commit: 90901fd2ef2e983806da81bc16114e7e5dce2b02 https://github.com/xwiki/xwiki-commons/commit/90901fd2ef2e983806da81bc16114e... Author: Vincent Massol <[email protected]> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/Base64BinaryStringEncoderTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/HexBinaryStringEncoderTest.java M xwiki-commons-core/xwiki-commons-crypto/xwiki-commons-crypto-common/src/test/java/org/xwiki/crypto/internal/encoder/UrlBase64BinaryStringEncoderTest.java Log Message: ----------- [Misc] Replace string concatenations with text blocks in encoder tests (SonarQube java:S6126) Commit: d1ea24d5768a7153dd5cf6a8d19630cdb038bb83 https://github.com/xwiki/xwiki-commons/commit/d1ea24d5768a7153dd5cf6a8d19630... Author: Vincent Massol <[email protected]> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/event/LogEventTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-filesystem/src/test/java/org/xwiki/store/blob/internal/FileSystemBlobStoreTest.java Log Message: ----------- [Misc] Fix expected/actual argument order in assertions (SonarQube java:S3415) Commit: e320dbb92a84e28a026e26703c40aac6af146cdb https://github.com/xwiki/xwiki-commons/commit/e320dbb92a84e28a026e26703c40aa... Author: Vincent Massol <[email protected]> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/marker/TranslationMarkerTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/event/ActionExecutionEventTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/event/CancelableEventTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/filter/AlwaysMatchingEventFilterTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/filter/FixedNameEventFilterTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-api/src/test/java/org/xwiki/store/blob/BlobRangeOptionTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of assertTrue/assertFalse with equals() (SonarQube java:S5785) Commit: ea8c42a09e4efe7006017b9f69d0ebf2587d54a1 https://github.com/xwiki/xwiki-commons/commit/ea8c42a09e4efe7006017b9f69d0eb... Author: Vincent Massol <[email protected]> Date: 2026-07-26 (Sun, 26 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/ExtensionPackager.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/FileExtensionRepository.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/integration/TestDataParser.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/internal/ZIPFileAssertComparator.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-common/src/main/java/org/xwiki/logging/internal/tail/AbstractFileLoggerTail.java Log Message: ----------- [Misc] Use try-with-resources where semantics are preserved (SonarQube java:S2093) * AbstractFileLoggerTail: extracted the read block into a private helper holding the try-with-resources (checkstyle NestedTryDepth); close order and error path unchanged. Compare: https://github.com/xwiki/xwiki-commons/compare/a19eb1ca9dc0%5E...ea8c42a09e4... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications