[xwiki/xwiki-docker] 7a57d0: XDOCKER-426: Harden the Dockerfile build steps (#100)
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-docker Commit: 7a57d036842a7847198ed3442b29f29acc70b4d6 https://github.com/xwiki/xwiki-docker/commit/7a57d036842a7847198ed3442b29f29... Author: Vincent Massol <[email protected]> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M 16/mariadb-tomcat/Dockerfile M 16/mysql-tomcat/Dockerfile M 16/postgres-tomcat/Dockerfile M 17/mariadb-tomcat/Dockerfile M 17/mysql-tomcat/Dockerfile M 17/postgres-tomcat/Dockerfile M 18.4/mariadb-tomcat/Dockerfile M 18.4/mysql-tomcat/Dockerfile M 18.4/postgres-tomcat/Dockerfile M 18/mariadb-tomcat/Dockerfile M 18/mysql-tomcat/Dockerfile M 18/postgres-tomcat/Dockerfile M template/Dockerfile Log Message: ----------- XDOCKER-426: Harden the Dockerfile build steps (#100) Applies the suggestions made while reviewing the Docker Official Images PR for XWiki 18.6.0: * Derive the LibreOffice symlink target from LIBREOFFICE_VERSION instead of globbing /opt (the command substitution was unquoted), and assert that it resolves to a soffice binary. That symlink is the only thing making JODConverter find LibreOffice, so an installation landing elsewhere must fail the build rather than produce an image where office import/export silently doesn't work. Pass -n to ln so that it replaces the symlink itself rather than dereferencing an existing one and creating the link inside the directory it points to. * Use "set -eux" instead of chaining commands with "&&", so that a command added later without its trailing "&&" cannot have its failure silently ignored, and so that each step is traced in the build log. * Verify the downloaded archives with the conventional binary-mode checksum format ("*" prefix and --strict). Co-authored-by: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-docker/settings/notifications
participants (1)
-
XWiki Notifications