[xwiki-contrib/application-releasenotes] abab1f: [Misc] Retry opening the screenshots picker sugges...
Branch: refs/heads/master Home: https://github.com/xwiki-contrib/application-releasenotes Commit: abab1f148a5f632a071662dabc46bad3bd717356 https://github.com/xwiki-contrib/application-releasenotes/commit/abab1f148a5... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/ReleaseNotesIT.java Log Message: ----------- [Misc] Retry opening the screenshots picker suggestions in the functional test * ReleaseNotesIT#screenshotsAreEditedThroughAnAttachmentPicker failed once on CI with a TimeoutException in SuggestInputElement#waitForNonTypedSuggestions, while every other test of the class passed and master was green. * The archived video shows why: after the inline form finishes loading, not a single frame changes for 15 seconds, then the frame holding the click changes by almost nothing and the next 30 seconds are the wait timing out. The widget gets neither the focus ring nor a caret nor a dropdown, so the pointer event never reached it. Nothing was still loading or moving, so no extra wait can help. * Retry the click while the dropdown is not open, and only then wait for the suggestions. The click is guarded by the dropdown state because clicking a widget whose dropdown is already open would close it again. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 600d8f5d000c27a3abcbb6d78140b4b07dd5ab2d https://github.com/xwiki-contrib/application-releasenotes/commit/600d8f5d000... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/ReleaseNotesIT.java A application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/po/ChangeInlinePage.java A application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/po/ChangeViewPage.java Log Message: ----------- [Misc] Retry opening the screenshots picker suggestions in the functional test * Move the screenshots picker interaction behind page objects, so the test drives the UI only through them: ChangeInlinePage for the change's inline edit form, which owns locating the picker, scrolling to it and opening its suggestions, and ChangeViewPage for the medium rendered on the change's own page. The test method no longer calls getDriver() at all. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 3889abc06e53ddcdf6c354148d9865e55946b789 https://github.com/xwiki-contrib/application-releasenotes/commit/3889abc06e5... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/ReleaseNotesIT.java A application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/po/ChangeInlinePage.java A application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/po/ChangeViewPage.java Log Message: ----------- Merge pull request #52 from xwiki-contrib/misc-attachment-picker-flicker [Misc] Retry opening the screenshots picker suggestions in the functional test Compare: https://github.com/xwiki-contrib/application-releasenotes/compare/205e091971... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications