Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: a867cee13dcc8c1bef91dbb586ca6363dac9819a https://github.com/xwiki/xwiki-platform/commit/a867cee13dcc8c1bef91dbb586ca6... Author: Vincent Massol <[email protected]> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-stores/xwiki-platform-eventstream-store-common/src/main/java/org/xwiki/eventstream/store/internal/DocumentEventListener.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Log a failure to save an event stream event as an error carrying its stack trace, instead of a warning carrying only the root cause: the event is lost and nothing else records it, so the failure prevents an important system from working Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 08e043feb30043ed657d48421103dd0e27583a4d https://github.com/xwiki/xwiki-platform/commit/08e043feb30043ed657d48421103d... Author: Vincent Massol <[email protected]> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-creationjob/src/main/java/org/xwiki/platform/wiki/creationjob/script/WikiCreationJobScriptServices.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-creationjob/src/test/java/org/xwiki/platform/wiki/creationjob/script/WikiCreationJobScriptServicesTest.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Log a wiki creation failure as an error carrying its stack trace: wiki creation is an important system and a failure leaves the new wiki half created * The failure is also kept as the script service's last error for the UI, but that only exposes the message, so the log is the only place where the cause can be found Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 72d3c126c9db4481c19d0db9b23dbd19a066cd11 https://github.com/xwiki/xwiki-platform/commit/72d3c126c9db4481c19d0db9b23db... Author: Vincent Massol <[email protected]> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWikiContext.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/AbstractXWikiStore.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/XWikiWebDriver.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Restore the throwable as the trailing SLF4J argument in TestUtils (x2), XWikiWebDriver, XWikiContext, XWikiAttachment and AbstractXWikiStore, instead of inlining the trace into the message through ExceptionUtils.getStackTrace() * A throwable given as the last argument reaches a structured field: ILoggingEvent's throwable proxy, XWiki's own LogEvent throwable, and the stack trace field of the ECS and OpenTelemetry encoders. Whoever renders the log then decides whether to show the trace, the way the job log displayer shows the root cause and keeps the trace one click away. A trace inlined in the message is dumped in full as unformatted text and leaves that field empty for every consumer * The three call stack markers keep their synthetic exception, now passed as a throwable as well Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 7d8554fec6489c6a2a595db18dfff06cee3f6501 https://github.com/xwiki/xwiki-platform/commit/7d8554fec6489c6a2a595db18dfff... Author: Vincent Massol <[email protected]> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-default/src/main/java/org/xwiki/url/internal/DefaultURLSecurityManager.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-default/src/test/java/org/xwiki/url/internal/DefaultURLSecurityManagerTest.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Restore the warning plus debug pair in DefaultURLSecurityManager instead of a single error with the stack trace: an unparsable URI comes from the request, so it can be hit on every request and there is nothing an administrator can fix * The root cause is in the warning so the message alone is diagnosable, and the full trace stays available at the debug level * Update DefaultURLSecurityManagerTest for the new messages Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 0f2b18576d914125558d991ea17ba2d6f5643acc https://github.com/xwiki/xwiki-platform/commit/0f2b18576d914125558d991ea17ba... Author: Vincent Massol <[email protected]> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/notify/XWikiPageNotification.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/InternalTemplateManager.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/provisioning/DefaultWikiCopier.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * XWikiPageNotification: restore the XWikiException wrapping. Its getFullMessage() already prints the stack trace, and its getMessage() prefixes the module and the error number, both of which a plain error(message, throwable) drops * DefaultWikiCopier: log the wrapping exception's own message again instead of a literal that duplicates it * InternalTemplateManager: drop the root cause from the path traversal warning, which describes where the check tripped rather than why the request was rejected. The diagnosis is the template name, which the message already gives Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 9ce3807368622aa760f874047766eec0e14e0bd2 https://github.com/xwiki/xwiki-platform/commit/9ce3807368622aa760f874047766e... Author: Vincent Massol <[email protected]> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-manager/src/main/java/org/xwiki/query/internal/DefaultQuery.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Convert the query filter logged by DefaultQuery to a String at the call site: a log statement captured in a job status is XStream serialized, and an argument whose class cannot be resolved when the status is read back is dropped entirely. A query filter can come from an extension, so its class is exactly the kind that fails to resolve Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/5982b0b8851b...9ce380736862 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications