Branch: refs/heads/stable-16.4.x Home: https://github.com/xwiki/xwiki-platform Commit: bce9643e855a03d37b95539eaae94d953dcf5e56 https://github.com/xwiki/xwiki-platform/commit/bce9643e855a03d37b95539eaae94... Author: Vincent Massol <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-useravatar/src/test/java/org/xwiki/rendering/macro/useravatar/IntegrationTests.java Log Message: ----------- [Misc] Convert a JUnit4-based rendering tests to JUnit5 (cherry picked from commit 95e312abc27130994e01a07f800ca9c548ec9ebb) Commit: d879a3e84370da9738c3efc2d17303da44081680 https://github.com/xwiki/xwiki-platform/commit/d879a3e84370da9738c3efc2d1730... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/main/java/org/xwiki/model/internal/reference/DefaultEntityReferenceValueProvider.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/main/java/org/xwiki/model/reference/EntityReferenceValueProvider.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/main/java/org/xwiki/model/script/LegacyModelScriptService.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultEntityReferenceValueProviderTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/script/LegacyModelScriptServiceTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentEntityReferenceValueProvider.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentMixedEntityReferenceValueProvider.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/resources/META-INF/components.txt M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/pom.xml R xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/internal/reference/DefaultEntityReferenceValueProvider.java R xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/reference/EntityReferenceValueProvider.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/script/ModelScriptService.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/resources/META-INF/components.txt R xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultEntityReferenceValueProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/converter/EntityReferenceConverterTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/script/ModelScriptServiceTest.java R xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentEntityReferenceValueProvider.java R xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentMixedEntityReferenceValueProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/META-INF/components.txt M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-useravatar/src/main/java/org/xwiki/rendering/internal/macro/useravatar/UserAvatarMacro.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-useravatar/src/test/java/org/xwiki/rendering/macro/useravatar/IntegrationTests.java Log Message: ----------- [Misc] Move some deprecated class from model-api to legacy (cherry picked from commit 4e2efc811fd359eaf87f1bc1e43e78d54777a801) Commit: 583dd0f981437276a8abfdb5e6a7079d4ddcab35 https://github.com/xwiki/xwiki-platform/commit/583dd0f981437276a8abfdb5e6a70... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/internal/reference/AbstractReferenceEntityReferenceResolver.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/reference/EntityReference.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultReferenceEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/RelativeStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/WithParametersTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/converter/EntityReferenceConverterTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceSetTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java Log Message: ----------- XWIKI-22702: Provide parentType information in EntityReference (#3698) * Provide EntityReference#getParentType * Use it in AbstractReferenceEntityReferenceResolver * Provide a new test * add more explanatory tests * Improve a bit the checks when setting the fallbackParentType parameter value * use back parentType parameter key name (cherry picked from commit c5b9c6051462122a37d8e7001c4776abed599ea8) Commit: b6efa941bc349836779a923a46ead7fb9ffaf6f5 https://github.com/xwiki/xwiki-platform/commit/b6efa941bc349836779a923a46ead... Author: Thomas Mortagne <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/converter/EntityReferenceConverterTest.java Log Message: ----------- XWIKI-22702: Provide parentType information in EntityReference * remove unused import (cherry picked from commit b845a4a73abc91502eada9b1ddbef8b57045eb91) Commit: 6e950fb69384abf5b9634cc436cdb6a5b6a87845 https://github.com/xwiki/xwiki-platform/commit/6e950fb69384abf5b9634cc436cdb... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/reference/EntityReference.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java Log Message: ----------- XWIKI-22702: Provide parentType information in EntityReference * Minor improvment (cherry picked from commit a5f4f86ce0368f5d7a1b1927f3d3e13ebbc6db6f) Commit: 8c736ac4f4667b947e35ab69c3f1f79d8dcd75d1 https://github.com/xwiki/xwiki-platform/commit/8c736ac4f4667b947e35ab69c3f1f... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultReferenceEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/RelativeStringEntityReferenceResolverTest.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/AbstractRelativeResourceReferenceEntityReferenceResolver.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/RelativeAttachmentResourceReferenceEntityReferenceResolver.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/RelativeDocumentResourceReferenceEntityReferenceResolver.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/RelativePageAttachmentResourceReferenceEntityReferenceResolver.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/RelativePageResourceReferenceEntityReferenceResolver.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/RelativeResourceReferenceEntityReferenceResolver.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/RelativeSpaceResourceReferenceEntityReferenceResolver.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/resources/META-INF/components.txt M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/test/java/org/xwiki/rendering/internal/resolver/DefaultResourceReferenceEntityReferenceResolverTest.java A xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/test/java/org/xwiki/rendering/internal/resolver/RelativeResourceReferenceEntityReferenceResolverTest.java Log Message: ----------- XWIKI-22681: Provide a relative ResourceReferenceEntityReferenceResolver (#3673) (cherry picked from commit 65acde038d0b0cddb9a7012e0a29e6bcae852c83) Commit: c9b78897f62dc396498e4a44bed5702ef4aacbaf https://github.com/xwiki/xwiki-platform/commit/c9b78897f62dc396498e4a44bed57... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/checkstyle/checkstyle-suppressions.xml M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java A xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/InternalCopyOrMoveJobException.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/RenameJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/job/question/EntitySelection.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/MoveJobTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/RenameJobTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page (#3634) The idea of this work is to: * Change the way AbstractCopyOrMoveJob works to perform computation of couple source/target documents before processing them * Provide a way to access that map source/target documents * Use that information when performing a call to ReferenceRenamer to define if a relative untyped link should be handled or not The PR provides mainly: - new APIs in ReferenceRenamer and MacroRefactoring to integrate the map of references that have been moved as part of same job - refactorings of AbstractCopyOrMoveJob: * specific computation of getEntities to actually visit the hierarchy and populate the entities with the couple of source/target documents * new abstract methods to avoid duplications (not strictly needed for this work) * new method to retrieve the map of source/target documents - new conditions in ResourceReferenceRenamer to decide if a link should be renamed or not: most of the logic of the fix is encoded there (see also clarifications) - new calls in XWiki#updateLinksForRename and BackLinkUpdaterListener#updateBackLinks to give the map of source/target when calling the rename of references - new integration test simulating the scenario indicated in the ticket and also performing a supplementary check related to a regression found afterwards - same integration test also performed on a subwiki in SubWikiIT The refactoring of references is currently called at two places: by the BackLinkUpdaterListener for all backlinks after a document has been renamed (triggered by a document event) by XWiki#updateLinksForRename to rename the internal links of the current document (which is always a call to updateResourceReferenceRelative, see below) The problem of XWIKI-12987 is that XWiki#updateLinksForRename is called first and does perform an absolute rename of the relative links. Now ResourceReferenceRenamer APIs names might be misleading: updateResourceReferenceRelative and updateResourceReferenceAbsolute are not about the references being absolute or relative: it's about the renamed references being absolute or relative respectively to the current document. It took me a while to integrate this, and I'm still struggling a bit with it. So the problem was to find a proper condition to decide when to not refactor links, for this I'm performing a check for assessing if a link is absolute or not, by trying to resolve the ResourceReference without any parameter: if the result equals the reference with parameter then it was absolute. Then for the updateResourceReferenceAbsolute the idea is to only perform update of the links, if the provided link is absolute, or if it's relative but the current document hasn't been moved as part of same job: in such case we do need to update the relative link, because there won't be a call to XWiki#updateLinksForRename on that document to update the link, we only get the call from BackLinkUpdaterListener. For the updateResourceReferenceRelative the check is a bit more complex. We only update links that are relative here, we don't want to update absolute references (is that correct? Can't find a counter example right now). Then since we only perform refactoring of links relative to current document, we also check that the link about to be refactored is not related to pages that are part of the moved document in the same job: if those are also moved in the same job, then they're moved using same "direction", they're part of same hierarchy and we don't want to change the relative links wrt to them. This check is the main part of avoiding to update the relative links. And finally we perform the update of the link only if the doc actually exists: we would create absolute links for those not existing doc, which doesn't make sense, we should keep the relative link we don't really know what the user wanted to do with those. Note that we could do the same check in updateResourceReferenceAbsolute but we don't really have the need since this is only called from the BackLinkUpdaterListener and if I'm correct we'll never have registered backlinks for a not existing doc. Note that initially we discussed about using untyped link as a condition to perform or not the refactoring: I dropped the idea because we currently always create image resource references as untyped references from the WYSIWYG editor. Note that this work currently includes a known regression when renaming links on the form `page:../SubSpace/Page`, this is going to be handled in further work. (cherry picked from commit fc01c140169d8f1f39eeb98435639ec28bd56f4c) Commit: b1f583c4224a513817df76223ddb37182b0bfaea https://github.com/xwiki/xwiki-platform/commit/b1f583c4224a513817df76223ddb3... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * ugly fix of the page reference regression and cover it with integration test (cherry picked from commit 60b054243cdb734718ec0e3e704658c969c73dc3) Commit: 1b14fe7ff040143be5e60a5fd9c7177597f1ed60 https://github.com/xwiki/xwiki-platform/commit/1b14fe7ff040143be5e60a5fd9c71... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/DeletePageIT.java M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java Log Message: ----------- XWIKI-22571: Backlinks update changes an absolute reference to the moved page into one relative to the current wiki (#3654) * Use default serializer if the wiki is present in a link, not the compact serializer * Provide unit test and integration test to cover this * Fix DeletePageIT tests * simplify condition by using the relative resource reference resolver * fix tests (cherry picked from commit d2d9a57524b93fc571c2d796274e0530a2989165) Commit: a48e4e39ef74f29cd69b84c2079c30fec2b3a250 https://github.com/xwiki/xwiki-platform/commit/a48e4e39ef74f29cd69b84c2079c3... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java Log Message: ----------- XWIKI-22571: Backlinks update changes an absolute reference to the moved page into one relative to the current wiki * Update test (cherry picked from commit 4904b347da8c759aa1b2fc295a25e0bd285466ac) Commit: 5bcd9e94a058b8e845d8a60b8d2da19772c1d9bf https://github.com/xwiki/xwiki-platform/commit/5bcd9e94a058b8e845d8a60b8d2da... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/RenameJobTest.java Log Message: ----------- XWIKI-22717: Can't move an application created with AWM * Fix problems when trying to rename an entire space * Ensure to cover this UC in unit tests (cherry picked from commit ba4bd1e0d4d9ee9af60d769cb57c74d5d77d7bee) (cherry picked from commit 61fd57777ec6e21dcf15e5723fc13214ab209b51) Commit: 124ef73a0eb1b1f83394aa9eebaf1205f74f1d41 https://github.com/xwiki/xwiki-platform/commit/124ef73a0eb1b1f83394aa9eebaf1... Author: Simon Urli <[email protected]> Date: 2025-02-26 (Wed, 26 Feb 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/ViewersIT.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/MoveJobTest.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/RefactoringStatusPage.java Log Message: ----------- XWIKI-22787: Pinned Pages are lost on space move for non admin user (#3886) * Start work to have specific handling of WebPreferences in case of move/rename/copy of a full space * Fix unused import * Provide integration test * Fix wrong conditions * Add unit tests (cherry picked from commit 594fd60dc4a60c36dfb9dc61c26dd1f95ee80556) Compare: https://github.com/xwiki/xwiki-platform/compare/9dfaf270f531...124ef73a0eb1 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications