Branch: refs/heads/XWIKI-24665-revert-structural Home: https://github.com/xwiki/xwiki-platform Commit: ba00062020eb3b4f1d935778158d1030f22b23db https://github.com/xwiki/xwiki-platform/commit/ba00062020eb3b4f1d935778158d1... Author: Vincent Massol <[email protected]> Date: 2026-08-07 (Fri, 07 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/ActiveInstallsPingRunnable.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-validation/xwiki-platform-attachment-validation-api/src/main/java/org/xwiki/attachment/validation/AttachmentValidationScriptService.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/XarExtensionHandler.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/repository/InstalledExtensionSynchronizer.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-sources/src/main/java/org/xwiki/notifications/sources/internal/DefaultGroupingEventManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/rcs/XWikiRCSArchive.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/RefererStatsStoreItem.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R140600000XWIKI19869DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R4359XWIKI1459DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiURLFactoryServiceImpl.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/RatingDeletedEntityListener.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/RatingMovedEntityListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractReplaceUserJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/job/ReplaceUserJob.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/ExtensionStore.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/RepositoryManager.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/DefaultSolrIndexer.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractDocumentSkinExtensionPlugin.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Revert the sweep changes flagged by the statement-by-statement review of the whole sweep range, keeping the message improvements they were bundled with * Drop again the exception argument added to AttachmentValidationScriptService, XarExtensionHandler, InstalledExtensionSynchronizer, BaseElement, RefererStatsStoreItem, MyPersistentLoginManager, XWikiURLFactoryServiceImpl, DefaultModelBridge and RepositoryManager * Restore the root cause message in place of the exception object in DefaultGroupingEventManager, RatingDeletedEntityListener, RatingMovedEntityListener, AbstractReplaceUserJob, ReplaceUserJob and ExtensionStore, and restore the error plus debug pair in AbstractDocumentSkinExtensionPlugin * Restore the explicit toString() on the arguments logged by XWikiRCSArchive, FileSystemURLFactory, R140600000XWIKI19869DataMigration, R4359XWIKI1459DataMigration and DefaultSolrIndexer, so they reach the job log as Strings rather than as objects that may fail to deserialize * Rebuild the ActiveInstallsPingRunnable warning from a single String.format instead of duplicating the message across two branches Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications