[xwiki/xwiki-platform] 138a0c: [Misc] Apply the logging best practices to oldcore...
Branch: refs/heads/misc-logging-batch6 Home: https://github.com/xwiki/xwiki-platform Commit: 138a0c6749e0c6d909a6ce1d32af8c094c784af5 https://github.com/xwiki/xwiki-platform/commit/138a0c6749e0c6d909a6ce1d32af8... Author: Vincent Massol <[email protected]> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-versioncheck/src/main/java/org/xwiki/extension/versioncheck/internal/VersionCheckInitializer.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/thread/MailSenderInitializerListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/User.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/context/RequestInitializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/DocumentReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/pdf/FOPXSLFORenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/AbstractSheetBinder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/AbstractSkin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/PropertyConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/InternalTemplateManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R35102XWIKI7771DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/util/Util.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/document/DocumentRequiredRightsReader.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/document/DocumentRequiredRightsReaderTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/XWikiResource.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/AbstractSxAction.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/provisioning/DefaultWikiCopier.java Log Message: ----------- [Misc] Apply the logging best practices to oldcore and 5 more platform modules Closes out the SLF4J logging audit: the xwiki-platform-oldcore sites left over from the exceptions-discarded-in-a-catch pass, plus the last stragglers a re-run of both parsers surfaced elsewhere. * warn() in a catch now appends the root cause instead of dropping the exception; error() in a catch receives the caught exception itself. * XWiki.evaluateVelocity passed xe.getCause(), which is null when the exception has no cause, so no stack trace was ever logged. * VersionCheckInitializer passed the exception where a value was expected: the placeholder rendered literally and a warning printed a stack trace. * MailSenderInitializerListener announced the Prepare thread after stopping the Sender thread and vice versa. * User.isUserInGroup built its message with MessageFormat, XWikiResource used quotes and a trailing newline instead of brackets, DefaultWikiCopier logged the message-less form, AbstractSxAction used getMessage(). Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications