[xwiki-devs] [Proposal] Add variable substitution support in hibernate.cfg.xml for the "connection.url" property

Hi devs, I need to be able to configuration the location of the HSQLDB database/ directory in our installer when executing on windows7 (because on windows7 you cannot write to the ProgramFiles directory). I'm proposing to add variable substitution so that we can configure connectio.url for HSQLDB to point to the environment.permanentDirectory location. We would have: <property name="connection.url">jdbc:hsqldb:file:${environment.permanentDirectory)/database/xwiki_db;shutdown=true</property> Technical details: * I'll modify DBCPConnectionProvider. More specifically this part: String jdbcUrl = System.getProperty(Environment.URL); if (jdbcUrl == null) { jdbcUrl = props.getProperty(Environment.URL); } dbcpProperties.put("url", jdbcUrl); * And look for ${…} , extract the variable name and use the XWikiPropertiesConfigurationSource to get the value for that variable name, as a String. WDYT? Thanks -Vincent