Re: [xwiki-devs] [VOTE] Release XE 2.5M2

On 09/27/2010 01:49 PM, Sergiu Dumitriu wrote: I have to refactor DefaultPresentationBuilder from office-importer module so that it doesn't depend (runtime) on velocity and html macros. Otherwise I can't create the office preview macro: macros can't depend on the HTML macro, and office preview macro -> office preview -> office importer -> HTML macro. DefaultPresentationBuilder needs the HTML macro because it generates HTML elements that have no correspondent node in XDOM. Precisely, it generates an in-line frame that points to the first slide (a file in the attached presentation zip archive). I have two options: (1) modify DefaultPresentationBuilder to generate HTML elements that can be mapped to XDOM (e.g. put the presentation images and text directly in the page content, and don't use script tags or other HTML elements that can't be mapped to XDOM). (2) define macro markers specific to the presentation import and keep the current HTML output. This means we'll get something like: {{officepresentation}} <iframe ...></iframe> {{/officepresentation}} The macro markers are needed in order to protect the output of the office import in WYSIWYG mode. I'm for the first solution, but I haven't decided yet what to generate: (1a) list only the slide screen shots (1b) list slide screen shots followed by text extracted from each slide (1c) something else (there is a discussion thread opened for this). I need at least 1 day to finish this, provided we agree on the right solution. Thanks, Marius