+1 Thanks, On Tue, Feb 25, 2014 at 3:09 PM, Guillaume "Louis-Marie" Delhumeau < [email protected]> wrote:

+1!

2014-02-25 14:51 GMT+01:00 Ecaterina Moraru (Valica) <[email protected]>:

...

Hi,

In order to implement Flamingo skin ( http://jira.xwiki.org/browse/XWIKI-10093 ) we need to integrate the Bootstrap framework inside platform http://getbootstrap.com/

In this mail we should vote if you agree to integrate Bootstrap inside platform (or provide problems or alternatives).

Here is my +1.

Then I will ask you to help me find the best solution for this integration, read http://jira.xwiki.org/browse/XWIKI-10094

Thanks, Caty _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO

Vincent: I am splitting some existing templates in different files, in order to only rewrite those that are needed for the new skin. That means that upgrading an wiki that have a customized colibri will not be so easy because some files has been splitted. Is it a blocker from your point of view? 2014-02-25 16:02 GMT+01:00 [email protected] <[email protected]>:

+1 on the provision that we don't break backward compatibility, i.e. if someone has extended the Colibri skin, when that person upgrades to XWiki 6.x (for example), his/her skin still works. This could be achieved simply by moving existing templates in the Colibri skin module for example, while writing new templates based on bootstrap. Then once Flamingo is the default skin, we could deprecate Colibri and move it contrib so that users can still use it/install it but it wouldn't be avail by default.

Thanks -Vincent

On 25 Feb 2014 at 14:52:12, Ecaterina Moraru (Valica) ([email protected]) wrote:

Hi,

In order to implement Flamingo skin ( http://jira.xwiki.org/browse/XWIKI-10093 ) we need to integrate the Bootstrap framework inside platform http://getbootstrap.com/

In this mail we should vote if you agree to integrate Bootstrap inside platform (or provide problems or alternatives).

Here is my +1.

Then I will ask you to help me find the best solution for this integration, read http://jira.xwiki.org/browse/XWIKI-10094

Thanks, Caty _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

Historically, we've always done the first. Skins use the default /templates as long as they are part of the platform, they override the templates they need to override if the default doesn't suit their needs, and they're retired with all the templates they've been using. On 02/25/2014 12:32 PM, [email protected] wrote:

IMO this could be the occasion to rework the templates organization.

I think it would be better for backward compat to either - copy the existing templates to the colibri skin - or to have the ability to choose the templates dir to use for XWiki (see my previous mail on this) and package the existing ones as legacy templates later on.

Once Flamingo is out, we’ll drop support for Colibri IMO so it’s not like we’ll have to maintain 2 sets.

What do others think?

Thanks -Vincent

On 25 Feb 2014 at 18:14:42, Guillaume Louis-Marie Delhumeau ([email protected](mailto:[email protected])) wrote:

...

Vincent: I am splitting some existing templates in different files, in order to only rewrite those that are needed for the new skin. That means that upgrading an wiki that have a customized colibri will not be so easy because some files has been splitted.

Is it a blocker from your point of view?

2014-02-25 16:02 GMT+01:00 [email protected] :

...

+1 on the provision that we don't break backward compatibility, i.e. if someone has extended the Colibri skin, when that person upgrades to XWiki 6.x (for example), his/her skin still works. This could be achieved simply by moving existing templates in the Colibri skin module for example, while writing new templates based on bootstrap. Then once Flamingo is the default skin, we could deprecate Colibri and move it contrib so that users can still use it/install it but it wouldn't be avail by default.

Thanks -Vincent

On 25 Feb 2014 at 14:52:12, Ecaterina Moraru (Valica) ([email protected]) wrote:

Hi,

In order to implement Flamingo skin ( http://jira.xwiki.org/browse/XWIKI-10093 ) we need to integrate the Bootstrap framework inside platform http://getbootstrap.com/

In this mail we should vote if you agree to integrate Bootstrap inside platform (or provide problems or alternatives).

Here is my +1.

Then I will ask you to help me find the best solution for this integration, read http://jira.xwiki.org/browse/XWIKI-10094

Thanks, Caty

-- Sergiu Dumitriu http://purl.org/net/sergiu

5 +1, vote passed. Thank you, Caty On Wed, Feb 26, 2014 at 10:34 AM, Denis Gervalle <[email protected]> wrote:

Guillaume,

It depends how you split. If your split keep the original .vm, and make it include the two new .vm you create, this change would be compatible with any skin overriding the original template. Anything else will surely break stuff and you should apply Vincent backward compatibility method.

The existing colibri templates should be moved to the colibri skin. A Junco/Colibri look could be provided by inheriting that skin. A Flamingo skin could be built over a new reorganized set of default templates, and use native bootstrap. For a while, that Flamingo skin could also provide Junco CSS extensions to provide existing old markup (still to update features, existing extensions, ...) a bootstrap look that fit better with Flamingo.

Thanks,

On Tue, Feb 25, 2014 at 6:14 PM, Guillaume "Louis-Marie" Delhumeau < [email protected]> wrote:

...

Vincent: I am splitting some existing templates in different files, in order to only rewrite those that are needed for the new skin. That means that upgrading an wiki that have a customized colibri will not be so easy because some files has been splitted.

Is it a blocker from your point of view?

2014-02-25 16:02 GMT+01:00 [email protected] <[email protected]>:

...

+1 on the provision that we don't break backward compatibility, i.e. if someone has extended the Colibri skin, when that person upgrades to XWiki 6.x (for example), his/her skin still works. This could be achieved simply by moving existing templates in the Colibri skin module for example, while writing new templates based on bootstrap. Then once Flamingo is the default skin, we could deprecate Colibri and move it contrib so that users can still use it/install it but it wouldn't be avail by default.

Thanks -Vincent

On 25 Feb 2014 at 14:52:12, Ecaterina Moraru (Valica) ( [email protected] ) wrote:

Hi,

In order to implement Flamingo skin ( http://jira.xwiki.org/browse/XWIKI-10093 ) we need to integrate the Bootstrap framework inside platform http://getbootstrap.com/

In this mail we should vote if you agree to integrate Bootstrap inside platform (or provide problems or alternatives).

Here is my +1.

Then I will ask you to help me find the best solution for this integration, read http://jira.xwiki.org/browse/XWIKI-10094

Thanks, Caty _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs