[xwiki-devs] DW creates too many revisions?
Hi devs, I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting. The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save". However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK. Is this discrepancy normal? Do we want it? Thanks -Vincent
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything. On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Jan 31, 2013, at 8:27 AM, Thomas Mortagne <[email protected]> wrote:
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything.
Ok that explains it. Now the question is: do we want that? Is it not strange for the user to have 2 initial revs? Is this temporary while waiting for the standard importer to be rewritten? Thanks -Vincent
On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
On Thu, Jan 31, 2013 at 9:41 AM, Vincent Massol <[email protected]> wrote:
On Jan 31, 2013, at 8:27 AM, Thomas Mortagne <[email protected]> wrote:
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything.
Ok that explains it.
Now the question is: do we want that?
Is it not strange for the user to have 2 initial revs?
Is this temporary while waiting for the standard importer to be rewritten?
It does not have anything to do with some limitation of the implementation, it's a choice to eat as less memory as possible. It's always possible to optimize it a bit by deciding to do that only when there is several attachments or deciding to separate attachments only when above a configured size, etc.
Thanks -Vincent
On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Thu, Jan 31, 2013 at 9:41 AM, Vincent Massol <[email protected]> wrote:
On Jan 31, 2013, at 8:27 AM, Thomas Mortagne <[email protected]> wrote:
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything.
Ok that explains it.
Now the question is: do we want that?
Is it not strange for the user to have 2 initial revs?
If those versions were one major version and some minor versions, and if those were imported starting first with the content, and next with the attachments (in minor version), I would saw this as an improvement. Currently it seems a little bit weird IMO.
Is this temporary while waiting for the standard importer to be rewritten?
Thanks -Vincent
On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
On Thu, Jan 31, 2013 at 12:18 PM, Denis Gervalle <[email protected]> wrote:
On Thu, Jan 31, 2013 at 9:41 AM, Vincent Massol <[email protected]> wrote:
On Jan 31, 2013, at 8:27 AM, Thomas Mortagne <[email protected]> wrote:
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything.
Ok that explains it.
Now the question is: do we want that?
Is it not strange for the user to have 2 initial revs?
If those versions were one major version and some minor versions, and if those were imported starting first with the content, and next with the attachments (in minor version), I would saw this as an improvement. Currently it seems a little bit weird IMO.
Right now the import is fully streamed and attachments are located before the content in a XAR XML page.
Is this temporary while waiting for the standard importer to be rewritten?
Thanks -Vincent
On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment" and the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1 revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Thu, Jan 31, 2013 at 3:30 PM, Thomas Mortagne <[email protected]>wrote:
On Thu, Jan 31, 2013 at 12:18 PM, Denis Gervalle <[email protected]> wrote:
On Thu, Jan 31, 2013 at 9:41 AM, Vincent Massol <[email protected]> wrote:
On Jan 31, 2013, at 8:27 AM, Thomas Mortagne <[email protected]
wrote:
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything.
Ok that explains it.
Now the question is: do we want that?
Is it not strange for the user to have 2 initial revs?
If those versions were one major version and some minor versions, and if those were imported starting first with the content, and next with the attachments (in minor version), I would saw this as an improvement. Currently it seems a little bit weird IMO.
Right now the import is fully streamed and attachments are located before the content in a XAR XML page.
Maybe, a third revision would do the tricks while keeping the streamed import: 1.1 Imported from XAR (just a save with what you had from the header) 1.2 Added attachement xxx 1.3 Updated content WDYT ?
Is this temporary while waiting for the standard importer to be
rewritten?
Thanks -Vincent
On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment"
and
the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1
revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
On Thu, Jan 31, 2013 at 8:10 PM, Denis Gervalle <[email protected]> wrote:
On Thu, Jan 31, 2013 at 3:30 PM, Thomas Mortagne <[email protected]>wrote:
On Thu, Jan 31, 2013 at 12:18 PM, Denis Gervalle <[email protected]> wrote:
On Thu, Jan 31, 2013 at 9:41 AM, Vincent Massol <[email protected]> wrote:
On Jan 31, 2013, at 8:27 AM, Thomas Mortagne <[email protected]
wrote:
Extension Manager does not use the standard importer and to be safe it import attachments separately in order to support anything.
Ok that explains it.
Now the question is: do we want that?
Is it not strange for the user to have 2 initial revs?
If those versions were one major version and some minor versions, and if those were imported starting first with the content, and next with the attachments (in minor version), I would saw this as an improvement. Currently it seems a little bit weird IMO.
Right now the import is fully streamed and attachments are located before the content in a XAR XML page.
Maybe, a third revision would do the tricks while keeping the streamed import:
1.1 Imported from XAR (just a save with what you had from the header) 1.2 Added attachement xxx 1.3 Updated content
WDYT ?
It's already what is done actually except that the last one is a major save but yes I could make sure to do a minor save if it's not the only one.
Is this temporary while waiting for the standard importer to be
rewritten?
Thanks -Vincent
On Wed, Jan 30, 2013 at 10:03 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've installed the UI of a wiki through DW and I've noticed that the Sandbox.WebHome page had 2 revisions instead of the 1 revision I was expecting.
The first revision has a comment that says "Import: add attachment"
and
the second rev has a comment of "Import: final save".
However, if I skip the DW and import the XAR, I'll get only 1
revision AFAIK.
Is this discrepancy normal? Do we want it?
Thanks -Vincent
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On 02/01/2013 05:51 AM, Thomas Mortagne wrote:
On Thu, Jan 31, 2013 at 8:10 PM, Denis Gervalle <[email protected]> wrote:
Maybe, a third revision would do the tricks while keeping the streamed import:
1.1 Imported from XAR (just a save with what you had from the header) 1.2 Added attachement xxx 1.3 Updated content
WDYT ?
It's already what is done actually except that the last one is a major save but yes I could make sure to do a minor save if it's not the only one.
The first one should be the major one, not the last one. The major change is that you're updating a document; each part of that process is a step, thus minor. -- Sergiu Dumitriu http://purl.org/net/sergiu
participants (4)
-
Denis Gervalle -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol