[xwiki-devs] [VOTE] "member" field of XWikiGroups objects is supposed to contains only one member
Hi devs, I recently created http://jira.xwiki.org/jira/browse/XWIKI-5149, this issue is due to the fact that XWikiGroupServiceImpl#listMemberForGroup is splitting the value of the "member" field based on white space and comma. That does not make sense IMO and makes impossible to have a user with a white space (and comma which is less common) in its name for a very bad reason. Also the name of the field is "member" and not "members". Last reason is that i think in all other places we don't take this value as a list. Note that this bug is mainly a pain for authenticators where you have to remember the real name of the user and have some collision handling to support use case users "somename" and "some name" coming for an external authentication server in which theses are two different users. WDYT ? Here is my +1. -- Thomas Mortagne
+1 On Fri, May 7, 2010 at 18:36, Thomas Mortagne <[email protected]>wrote:
Hi devs,
I recently created http://jira.xwiki.org/jira/browse/XWIKI-5149, this issue is due to the fact that XWikiGroupServiceImpl#listMemberForGroup is splitting the value of the "member" field based on white space and comma.
That does not make sense IMO and makes impossible to have a user with a white space (and comma which is less common) in its name for a very bad reason. Also the name of the field is "member" and not "members". Last reason is that i think in all other places we don't take this value as a list.
Note that this bug is mainly a pain for authenticators where you have to remember the real name of the user and have some collision handling to support use case users "somename" and "some name" coming for an external authentication server in which theses are two different users.
WDYT ?
Here is my +1.
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
I don't see a clear question, so I'm going to guess it: Should the "member" property of XWikiGroups be single select (only one value per object), and fix the code in XWikiGroupServiceImpl accordingly? +1 On 05/07/2010 06:36 PM, Thomas Mortagne wrote:
Hi devs,
I recently created http://jira.xwiki.org/jira/browse/XWIKI-5149, this issue is due to the fact that XWikiGroupServiceImpl#listMemberForGroup is splitting the value of the "member" field based on white space and comma.
That does not make sense IMO and makes impossible to have a user with a white space (and comma which is less common) in its name for a very bad reason. Also the name of the field is "member" and not "members". Last reason is that i think in all other places we don't take this value as a list.
Note that this bug is mainly a pain for authenticators where you have to remember the real name of the user and have some collision handling to support use case users "somename" and "some name" coming for an external authentication server in which theses are two different users.
WDYT ?
Here is my +1.
-- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 Thanks, Marius On 05/07/2010 07:36 PM, Thomas Mortagne wrote:
Hi devs,
I recently created http://jira.xwiki.org/jira/browse/XWIKI-5149, this issue is due to the fact that XWikiGroupServiceImpl#listMemberForGroup is splitting the value of the "member" field based on white space and comma.
That does not make sense IMO and makes impossible to have a user with a white space (and comma which is less common) in its name for a very bad reason. Also the name of the field is "member" and not "members". Last reason is that i think in all other places we don't take this value as a list.
Note that this bug is mainly a pain for authenticators where you have to remember the real name of the user and have some collision handling to support use case users "somename" and "some name" coming for an external authentication server in which theses are two different users.
WDYT ?
Here is my +1.
participants (4)
-
Denis Gervalle -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne