XWikiAuthServiceImpl - Redundant replaceAll ?
Hi all, In user/impl/xwiki/XWikiAuthServiceImpl.java i read: protected String findUser(String susername2, XWikiContext context) throws XWikiException { String susername = susername2.replaceAll(" ", ""); susername = susername.replaceAll(" ", ""); [...] Why are we calling replaceAll method called twice ? It seems useless, what have I missed ? Thanks, Pablo
Indeed, a bug. I'll fix this as soon as ObjectWeb finishes the nightly backup, which makes every operation take about 5 minutes. On 4/17/07, Pablo Oliveira <[email protected]> wrote:
Hi all,
In user/impl/xwiki/XWikiAuthServiceImpl.java i read: protected String findUser(String susername2, XWikiContext context) throws XWikiException { String susername = susername2.replaceAll(" ", "");
susername = susername.replaceAll(" ", "");
[...]
Why are we calling replaceAll method called twice ? It seems useless, what have I missed ?
Thanks,
Pablo
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
Sergiu, I don't recall a commit on this. Did you get to do it? Thanks -Vincent On Apr 18, 2007, at 1:12 AM, Sergiu Dumitriu wrote:
Indeed, a bug. I'll fix this as soon as ObjectWeb finishes the nightly backup, which makes every operation take about 5 minutes.
On 4/17/07, Pablo Oliveira <[email protected]> wrote: Hi all,
In user/impl/xwiki/XWikiAuthServiceImpl.java i read: protected String findUser(String susername2, XWikiContext context) throws XWikiException { String susername = susername2.replaceAll (" ", "");
susername = susername.replaceAll(" ", "");
[...]
Why are we calling replaceAll method called twice ? It seems useless, what have I missed ?
Thanks,
Pablo
-- You receive this message as a subscriber of the xwiki- [email protected] mailing list. To unsubscribe: mailto: [email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
-- You receive this message as a subscriber of the xwiki- [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
participants (3)
-
Pablo Oliveira -
Sergiu Dumitriu -
Vincent Massol