Re: [xwiki-commits] r2503 - in xwiki/trunk/web/standard/src/main/webapp/skins: albatross dodo finch
On Mar 25, 2007, at 10:22 AM, Marta Girdea wrote:
Author: marta_girdea Date: 2007-03-25 10:22:52 +0200 (Sun, 25 Mar 2007) New Revision: 2503
Modified: xwiki/trunk/web/standard/src/main/webapp/skins/albatross/ contentview.vm xwiki/trunk/web/standard/src/main/webapp/skins/dodo/view.vm xwiki/trunk/web/standard/src/main/webapp/skins/finch/contentview.vm Log: XWIKI-1006: Add new #footnote macro Automatic call of #putFootnotes at the end of the page
What is this new feature of footnotes at the bottom of pages in our skins? I think that ideally this new feature should have warranted a JIRA issue so that it could have appeared in the release notes and users know to expect this new feature (which some may have been awaiting for). Note that this is different than creating a new footnote macro. Am I missing something? :) Thanks -Vincent
Vincent Massol a écrit :
On Mar 25, 2007, at 10:22 AM, Marta Girdea wrote:
Author: marta_girdea Date: 2007-03-25 10:22:52 +0200 (Sun, 25 Mar 2007) New Revision: 2503
Modified:
xwiki/trunk/web/standard/src/main/webapp/skins/albatross/contentview.vm xwiki/trunk/web/standard/src/main/webapp/skins/dodo/view.vm xwiki/trunk/web/standard/src/main/webapp/skins/finch/contentview.vm Log: XWIKI-1006: Add new #footnote macro Automatic call of #putFootnotes at the end of the page
What is this new feature of footnotes at the bottom of pages in our skins?
I think that ideally this new feature should have warranted a JIRA issue so that it could have appeared in the release notes and users know to expect this new feature (which some may have been awaiting for). Note that this is different than creating a new footnote macro. Am I missing something? :)
Thanks -Vincent
I think what your missing is that a footnote macro that does not put the footnote at the bottom of the page is useless.. So you need to call it after the rendering of the page. Here the call is in the skin.. It's probably the right way to do it. I think it is sufficient to have the XWIKI-1006 task for that
------------------------------------------------------------------------
-- You receive this message as a subscriber of the [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
-- Ludovic Dubost Blog: http://www.ludovic.org/blog/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost AIM: nvludo Yahoo: ludovic
On Mar 28, 2007, at 12:54 AM, Ludovic Dubost wrote:
Vincent Massol a écrit :
On Mar 25, 2007, at 10:22 AM, Marta Girdea wrote:
Author: marta_girdea Date: 2007-03-25 10:22:52 +0200 (Sun, 25 Mar 2007) New Revision: 2503
Modified: xwiki/trunk/web/standard/src/main/webapp/skins/albatross/ contentview.vm xwiki/trunk/web/standard/src/main/webapp/skins/dodo/view.vm xwiki/trunk/web/standard/src/main/webapp/skins/finch/ contentview.vm Log: XWIKI-1006: Add new #footnote macro Automatic call of #putFootnotes at the end of the page
What is this new feature of footnotes at the bottom of pages in our skins?
I think that ideally this new feature should have warranted a JIRA issue so that it could have appeared in the release notes and users know to expect this new feature (which some may have been awaiting for). Note that this is different than creating a new footnote macro. Am I missing something? :)
Thanks -Vincent
I think what your missing is that a footnote macro that does not put the footnote at the bottom of the page is useless.. So you need to call it after the rendering of the page. Here the call is in the skin.. It's probably the right way to do it. I think it is sufficient to have the XWIKI-1006 task for that
No... :-) I've already discussed this offline with Sergiu and he agreed with me. Here's why: - 1006 is about adding a macro like any other macro (toc, etc). It's to be used by users. It's an issue in the "Macro" component in JIRA. - The change is about modifying existing skin(s) to add a new feature, namely the support for footnotes. When users look at release notes they need to see what's new, what's modified and make an educated decision on whether they want to upgrade. Looking at the current releases notes in JIRA doesn't give a hint that the skins support footnotes now. It's a pity as it's a nice new feature we're adding... The JIRA strategy that we're following is that we need to make is user-oriented. It's for end users. It's not for us, we don't need it, we can look at commit messages to see what's being done, we can look at the source code, etc. JIRA issues are a communication channel with our users and as such they need to clearly show what's changed for them. They don't need (and shouldn't see) things like "remove $tdoc for permission improvement". This is not undestandable for a user. But something like "Allow setting permissions on translated version of documents" (this is a fake example just to make a point). Thanks -Vincent
Vincent Massol wrote:
The JIRA strategy that we're following is that we need to make is user-oriented. It's for end users. It's not for us, we don't need it, we can look at commit messages to see what's being done, we can look at the source code, etc. JIRA issues are a communication channel with our users and as such they need to clearly show what's changed for them. They don't need (and shouldn't see) things like "remove $tdoc for permission improvement". This is not undestandable for a user. But something like "Allow setting permissions on translated version of documents" (this is a fake example just to make a point).
I agree with you. Before adding new issue, I usually check is it already reported, but some of the issues have just non-descriptive subject. Documenting everything in JIRA could reduce duplicates and improve communication with users (e.g. what's reported, when it will be fixed etc.)
participants (3)
-
Ludovic Dubost -
Vincent Massol -
Zeljko Trogrlic