[xwiki-devs] [PROPOSAL] Apply patch attached XWIKI-2149 before 1.5M2 release
Hello devs, I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5. The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful. I'm +1 for it, and dedicated to apply it if we agree we want it. Jerome. (btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
+100 Ludovic Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
Depends how fast you can apply and *test* it, ideally with automated tests. If it can be done today then +1 otherwise, -0. I wonder why this was not raised before. It's not like it's something new. We should be more proactive. Thanks -Vincent On Jun 23, 2008, at 2:46 PM, Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
It's tomorrow already and I still have an issue with the patch. I need Marius's help with it. We'll see in the morning if it's big an issue or not, if it is, let's leave the patch for 1.6... Jerome.
Depends how fast you can apply and *test* it, ideally with automated tests.
If it can be done today then +1 otherwise, -0.
I wonder why this was not raised before. It's not like it's something new. We should be more proactive.
Thanks -Vincent
On Jun 23, 2008, at 2:46 PM, Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Jun 24, 2008, at 2:05 AM, Jerome Velociter wrote:
It's tomorrow already and I still have an issue with the patch. I need Marius's help with it. We'll see in the morning if it's big an issue or not, if it is, let's leave the patch for 1.6...
No, we could include it in RC1 since it's completely decoupled and not used in core. Thanks -Vincent
Depends how fast you can apply and *test* it, ideally with automated tests.
If it can be done today then +1 otherwise, -0.
I wonder why this was not raised before. It's not like it's something new. We should be more proactive.
Thanks -Vincent
On Jun 23, 2008, at 2:46 PM, Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
Hi devs, Before Jerome applies the patch, I need to make a small change regarding the following question: Do we include in the feed by default the entire description/content/summary of a feed entry or only the first N characters? There is a ContentLength length property that could have by default the -1 value, meaning the entire content, or N value, meaning the first N characters. For instance, in the current XWiki.BlogRssCode, the default length is 400 characters (so not the entire content). Thanks, Marius
On Jun 24, 2008, at 2:05 AM, Jerome Velociter wrote:
It's tomorrow already and I still have an issue with the patch. I need Marius's help with it. We'll see in the morning if it's big an issue or not, if it is, let's leave the patch for 1.6...
No, we could include it in RC1 since it's completely decoupled and not used in core.
Thanks -Vincent
Depends how fast you can apply and *test* it, ideally with automated tests.
If it can be done today then +1 otherwise, -0.
I wonder why this was not raised before. It's not like it's something new. We should be more proactive.
Thanks -Vincent
On Jun 23, 2008, at 2:46 PM, Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi devs,
Before Jerome applies the patch, I need to make a small change regarding the following question:
Do we include in the feed by default the entire description/content/summary of a feed entry or only the first N characters? There is a ContentLength length property that could have by default the -1 value, meaning the entire content, or N value, meaning the first N characters. For instance, in the current XWiki.BlogRssCode, the default length is 400 characters (so not the entire content).$
I am +0 with no limit as default setting. Another thing is jtidy printing a lot of warnings in the console. According to Marius, there is a way to make it quiet, using TIDY_FEED_CONFIG.setProperty("quiet", "yes"); But maybe we do not want it quiet anycase, so do you think it would be possible to catch that log, and push it in the feed plugin logger ? Jerome.
Thanks, Marius
On Jun 24, 2008, at 2:05 AM, Jerome Velociter wrote:
It's tomorrow already and I still have an issue with the patch. I need Marius's help with it. We'll see in the morning if it's big an issue or not, if it is, let's leave the patch for 1.6...
No, we could include it in RC1 since it's completely decoupled and not used in core.
Thanks -Vincent
Depends how fast you can apply and *test* it, ideally with automated tests.
If it can be done today then +1 otherwise, -0.
I wonder why this was not raised before. It's not like it's something new. We should be more proactive.
Thanks -Vincent
On Jun 23, 2008, at 2:46 PM, Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
So far we have 3 +1 (mine included), 1 +0, no -1 in favor of no limit by default. I'll change the patch accordingly. Also, see below,
Hi devs,
Before Jerome applies the patch, I need to make a small change regarding the following question:
Do we include in the feed by default the entire description/content/summary of a feed entry or only the first N characters? There is a ContentLength length property that could have by default the -1 value, meaning the entire content, or N value, meaning the first N characters. For instance, in the current XWiki.BlogRssCode, the default length is 400 characters (so not the entire content).$
I am +0 with no limit as default setting.
Another thing is jtidy printing a lot of warnings in the console. According to Marius, there is a way to make it quiet, using TIDY_FEED_CONFIG.setProperty("quiet", "yes"); But maybe we do not want it quiet anycase, so do you think it would be possible to catch that log, and push it in the feed plugin logger ?
JTidy allows me to register a message listener. Thus I'll add a utility class that catches all these messages and writes them to a given log4j logger. If anyone has something against it please reply ASAP. [snip] Thanks, Marius
On Tue, Jun 24, 2008 at 11:45 AM, Marius Dumitru Florea <[email protected]> wrote:
Hi devs,
Before Jerome applies the patch, I need to make a small change regarding the following question:
Do we include in the feed by default the entire description/content/summary of a feed entry or only the first N characters? There is a ContentLength length property that could have by default the -1 value, meaning the entire content, or N value, meaning the first N characters. For instance, in the current XWiki.BlogRssCode, the default length is 400 characters (so not the entire content).
+1 with no limit as the default. JV, whos likes to stay in his feed reader.
Marius Dumitru Florea wrote:
Hi devs,
Before Jerome applies the patch, I need to make a small change regarding the following question:
Do we include in the feed by default the entire description/content/summary of a feed entry or only the first N characters? There is a ContentLength length property that could have by default the -1 value, meaning the entire content, or N value, meaning the first N characters. For instance, in the current XWiki.BlogRssCode, the default length is 400 characters (so not the entire content).
+1 to no limit. -- Artem Melentyev
Jerome Velociter wrote:
Hello devs,
I would like to propose to apply Marius's patch attached to http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin to allow the creation of RSS/Atom feeds from any source"), in order to have it available in 1.5.
The patch comes with unit tests, and does not change existing code (it only adds new classes in the feed plugin/introduce a new util class in com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it is not harmful.
I'm +1 for it, and dedicated to apply it if we agree we want it.
Jerome.
(btw, this is a prerequisite for XE-240: Improve XE RSS feeds, marked as fix for M2)
+1 for including it in RC1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (7)
-
Artem Melentyev -
Jean-Vincent Drean -
Jerome Velociter -
Ludovic Dubost -
Marius Dumitru Florea -
Sergiu Dumitriu -
Vincent Massol