On 25 Jan 2015 at 22:56:33, [email protected] ([email protected](mailto:[email protected])) wrote:

Note that I’ve realized I’m missing some files, fixing it.

Should be better now :) Thanks -Vincent

Thanks -Vincent

On 25 Jan 2015 at 22:41:10, [email protected] ([email protected](mailto:[email protected])) wrote:

...

FTR I’ve executed it on commons and platform with:

mvn checkstyle:check -Dcheckstyle.failOnViolation=false > unstable.txt grep ERROR unstable.txt

Results: - commons: https://gist.github.com/vmassol/e920aa17e464a5b3f721 - platform: https://gist.github.com/vmassol/6968f5414115fb9f846f

Thanks -Vincent

On 25 Jan 2015 at 13:45:51, [email protected] ([email protected](mailto:[email protected])) wrote:

...

Hi devs,

I’ve created (and implemented) two JIRA issues to implementing automatic checking of our rule defined at http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#H40Unstab...

- http://jira.xwiki.org/browse/XCOMMONS-730 - http://jira.xwiki.org/browse/XCOMMONS-731

I’ve committed them which means the build is now failing on master and we need to fix it ASAP.

To check locally just execute: mvn checkstyle:check

Please all help in removing the @Unstable annotations that shouldn’t be there anymore.

Let me know if you don’t agree!

Thanks -Vincent