Hi Vincent, On Fri, Oct 17, 2008 at 1:01 PM, Vincent Massol <[email protected]> wrote:

+0

Open questions in my mind:

* I'm still unsure how the integration will be done, especially regarding the webdav servlet. I would have liked to see a quick email explaining how webdav is going to be integrated in XE for example before moving things. Do we need to modify web/standard's web.xml?

Ok, Following are the steps what need to happen : 1. xwiki-webdav module's jar file (+ deps) need to end up inside WEB-INF/lib (A maven dependancy would do) 2. xwiki-webdav-pluign's jar file also need to end up inside WEB-INF/lib directory. 3. WEB-INF/xwiki.cfg need to include an entry about the xwiki-webdav-plugin (/enterprise/trunk/web/pom.xml need to be modified) 4. xwiki-rootwebapp need to end up inside /webapps/root/ (need to modify assembly files) 5. web/stadard's web.xml need to be modified to include entries about the webdav servlet. 6. web & skin modules need to be patched for UI integration. I'm having a problem with the webdav module's integration tests (can't get them to run properly with a top-level build) at the moment. Will update as soon as i fix it.

* Regarding foxwiki I'm not sure it's a tool but more like a product/ project, no? The tools were meant to be build tools mostly or tools to help build other modules. This is not the case for foxwiki which suggest to me it might not be in the right location. A top level project sounds a better place. If you think it's too big for that then a top level tools project maybe? Also, Florin is working on an office .NET plugin for MS Office. Where would it go? I think they are both in the same category so either they are both a top level project or they could be grouped under the same "tools"/"integration"/whatever project. WDYT?

I like the idea of a top level tools project.

* We now need to vote Asiri to become a core committer. However I don't know if Asiri is ready to be a core committer yet. I also haven't reviewed his code yet so I'll need to do that before I can give an opinion.

* I would have preferred doing a review before moving the code but I guess all the other committers who have voted +1 have done so (Thomas and Sergiu), right?. Also only 2 committers have voted +1 (Thomas and Sergiu) so that's not much which tends to suggest to me the code hasn't really been fully reviewed by the committers. * Are the tests good enough both in term of quality and coverage?

I'm still working on the set of integration tests. they run fine when they are invoked from the project's own directory but when they are run as part of the whole trunk's build, they fail. I'm looking into it now. Thanks. - Asiri

Thanks -Vincent

On Oct 15, 2008, at 7:18 PM, Asiri Rathnayake wrote:

...

Hi Devs,

Beginning from 1.7M1 release our new webdav module will be part of the standard XE distribution. For this to happen, we need to move the corresponding projects from sandbox into trunk. Following are the locations we have discussed so far :

1. [xwiki-rootwebapp] :

http://svn.xwiki.org/svnroot/xwiki/platform/xwiki-tools/trunk/xwiki-rootweba...

...

2. [xwiki-webdav] : http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-webdav

3. [xwiki-webdav-plugin] : http://svn.xwiki.org/svnroot/xwiki/platform/xwiki-plugins/trunk/webdav

4. [foxwiki] : http://svn.xwiki.org/svnroot/xwiki/platform/xwiki-tools/trunk/foxwiki

Here's my +1 for moving these projects into corresponding locations.

Thanks.

- Asiri _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs