[xwiki-devs] [Vote] Use the Date Picker from AppWithinMinutes as the default picker for Date XClass properties
Here's the commit https://github.com/xwiki/xwiki-platform/commit/a6f4bd499fc2b1cf3757d423205a4... . The main changes are: * Move the JS/CSS of the date picker used by AppWithinMinutes into the file system (/resources/uicomponents/widgets/datepicker). * Apply checkstyle to DateProperty and DateClass. * Modify DateClass to use the AWM date picker when the 'picker' meta property is set. * Add back the 'picker' meta property to Date property (in DateMetaClass) to allow developers to use a different picker than the default one (or no picker at all). * Use Boolean property for 'picker' and 'emptyIsToday' meta properties (was Number property). Since a Boolean property is stored as an integer property the only difference will be visually (checkbox instead of text input). I'd like to merge this into the platform. My +1. Thanks, Marius
On 10/24/2012 12:38 PM, Marius Dumitru Florea wrote:
Here's the commit https://github.com/xwiki/xwiki-platform/commit/a6f4bd499fc2b1cf3757d423205a4... . The main changes are: * Move the JS/CSS of the date picker used by AppWithinMinutes into the file system (/resources/uicomponents/widgets/datepicker). * Apply checkstyle to DateProperty and DateClass. * Modify DateClass to use the AWM date picker when the 'picker' meta property is set. * Add back the 'picker' meta property to Date property (in DateMetaClass) to allow developers to use a different picker than the default one (or no picker at all). * Use Boolean property for 'picker' and 'emptyIsToday' meta properties (was Number property). Since a Boolean property is stored as an integer property the only difference will be visually (checkbox instead of text input).
I'd like to merge this into the platform. My +1.
+1, looks good. -- Sergiu Dumitriu http://purl.org/net/sergiu/
I followed Sergiu's suggestion and moved the Date displayer in a template (displayer_date.vm). I'd like to merge this before 4.3M2. Anyone against it? We need to have a date picker for date properties by default! Thanks, Marius On Wed, Oct 24, 2012 at 7:38 PM, Marius Dumitru Florea <[email protected]> wrote:
Here's the commit https://github.com/xwiki/xwiki-platform/commit/a6f4bd499fc2b1cf3757d423205a4... . The main changes are: * Move the JS/CSS of the date picker used by AppWithinMinutes into the file system (/resources/uicomponents/widgets/datepicker). * Apply checkstyle to DateProperty and DateClass. * Modify DateClass to use the AWM date picker when the 'picker' meta property is set. * Add back the 'picker' meta property to Date property (in DateMetaClass) to allow developers to use a different picker than the default one (or no picker at all). * Use Boolean property for 'picker' and 'emptyIsToday' meta properties (was Number property). Since a Boolean property is stored as an integer property the only difference will be visually (checkbox instead of text input).
I'd like to merge this into the platform. My +1.
Thanks, Marius
On 11/02/2012 08:09 AM, Marius Dumitru Florea wrote:
I followed Sergiu's suggestion and moved the Date displayer in a template (displayer_date.vm). I'd like to merge this before 4.3M2. Anyone against it? We need to have a date picker for date properties by default!
+1 Jerome
Thanks, Marius
On Wed, Oct 24, 2012 at 7:38 PM, Marius Dumitru Florea <[email protected]> wrote:
Here's the commit https://github.com/xwiki/xwiki-platform/commit/a6f4bd499fc2b1cf3757d423205a4... . The main changes are: * Move the JS/CSS of the date picker used by AppWithinMinutes into the file system (/resources/uicomponents/widgets/datepicker). * Apply checkstyle to DateProperty and DateClass. * Modify DateClass to use the AWM date picker when the 'picker' meta property is set. * Add back the 'picker' meta property to Date property (in DateMetaClass) to allow developers to use a different picker than the default one (or no picker at all). * Use Boolean property for 'picker' and 'emptyIsToday' meta properties (was Number property). Since a Boolean property is stored as an integer property the only difference will be visually (checkbox instead of text input).
I'd like to merge this into the platform. My +1.
Thanks, Marius
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 Thanks, Caty On Fri, Nov 2, 2012 at 10:20 AM, Jerome Velociter <[email protected]>wrote:
On 11/02/2012 08:09 AM, Marius Dumitru Florea wrote:
I followed Sergiu's suggestion and moved the Date displayer in a template (displayer_date.vm). I'd like to merge this before 4.3M2. Anyone against it? We need to have a date picker for date properties by default!
+1
Jerome
Thanks, Marius
On Wed, Oct 24, 2012 at 7:38 PM, Marius Dumitru Florea <mariusdumitru.florea@xwiki.**com <[email protected]>> wrote:
Here's the commit https://github.com/xwiki/**xwiki-platform/commit/** a6f4bd499fc2b1cf3757d423205a41**9315749603<https://github.com/xwiki/xwiki-platform/commit/a6f4bd499fc2b1cf3757d423205a419315749603> . The main changes are: * Move the JS/CSS of the date picker used by AppWithinMinutes into the file system (/resources/uicomponents/**widgets/datepicker). * Apply checkstyle to DateProperty and DateClass. * Modify DateClass to use the AWM date picker when the 'picker' meta property is set. * Add back the 'picker' meta property to Date property (in DateMetaClass) to allow developers to use a different picker than the default one (or no picker at all). * Use Boolean property for 'picker' and 'emptyIsToday' meta properties (was Number property). Since a Boolean property is stored as an integer property the only difference will be visually (checkbox instead of text input).
I'd like to merge this into the platform. My +1.
Thanks, Marius
______________________________**_________________ devs mailing list [email protected] http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
______________________________**_________________ devs mailing list [email protected] http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
participants (4)
-
Ecaterina Moraru (Valica) -
Jerome Velociter -
Marius Dumitru Florea -
Sergiu Dumitriu