Re: [xwiki-devs] [xwiki-notifications] r14997 - in sandbox/xwiki-officeimporter: . src/main/java/org/xwiki/officeimporter/html/cleaner src/main/java/org/xwiki/officeimporter/transformer src/main/java/org/xwiki/officeimporter/utils
asiri (SVN) wrote:
Author: asiri Date: 2009-01-01 11:43:23 +0100 (Thu, 01 Jan 2009) New Revision: 14997
Modified: sandbox/xwiki-officeimporter/pom.xml sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/html/cleaner/OfficeImporterHTMLCleaner.java sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/HtmlToXWikiPresentationTransformer.java sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/HtmlToXWikiTransformer.java sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/HtmlToXWikiTwoZeroTransformer.java sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/OfficeToHtmlTransformer.java sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/utils/ImporterContext.java Log: * Fixed compile errors * Fixed failing test cases
However I couldn't get rid of following two test scoped dependencies despite all my efforts :
2.
<dependency> <groupId>com.xpn.xwiki.platform</groupId> <artifactId>xwiki-core</artifactId> <version>${pom.version}</version> <scope>test</scope> </dependency>
This is something I don't have any clue about. Removing this dependency breaks the tests with following trace : http://tinypaste.com/pre.php?id=10b99
I initially thought this is because DefaultDocumentAccessBridge is defined inside xwiki-core (by looking at the trace). But xwiki-redering faces the same situation but avoids this xwiki-core dependency. I wonder if the dependency on xwiki-velocity module has to do something with this.
For testing, xwiki-rendering defines its own mock implementation of the document access bridge. You should look in the src/test directory of xwiki-rendering to see what it does there. -- Sergiu Dumitriu http://purl.org/net/sergiu/
Hi Sergiu, On Sun, Jan 4, 2009 at 9:16 AM, Sergiu Dumitriu <[email protected]> wrote:
asiri (SVN) wrote:
Author: asiri Date: 2009-01-01 11:43:23 +0100 (Thu, 01 Jan 2009) New Revision: 14997
Modified: sandbox/xwiki-officeimporter/pom.xml
sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/html/cleaner/OfficeImporterHTMLCleaner.java
sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/HtmlToXWikiPresentationTransformer.java
sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/HtmlToXWikiTransformer.java
sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/HtmlToXWikiTwoZeroTransformer.java
sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/transformer/OfficeToHtmlTransformer.java
sandbox/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/utils/ImporterContext.java
Log: * Fixed compile errors * Fixed failing test cases
However I couldn't get rid of following two test scoped dependencies despite all my efforts :
2.
<dependency> <groupId>com.xpn.xwiki.platform</groupId> <artifactId>xwiki-core</artifactId> <version>${pom.version}</version> <scope>test</scope> </dependency>
This is something I don't have any clue about. Removing this dependency breaks the tests with following trace : http://tinypaste.com/pre.php?id=10b99
I initially thought this is because DefaultDocumentAccessBridge is defined inside xwiki-core (by looking at the trace). But xwiki-redering faces the same situation but avoids this xwiki-core dependency. I wonder if the dependency on xwiki-velocity module has to do something with this.
For testing, xwiki-rendering defines its own mock implementation of the document access bridge. You should look in the src/test directory of xwiki-rendering to see what it does there.
I got this fixed by adding a MockDocumentAccessBridge as adviced by vincent. Thanks. - Asiri
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Asiri Rathnayake -
Sergiu Dumitriu