Re: [xwiki-devs] [xwiki-notifications] r19183 - in platform/core/trunk/xwiki-officeimporter: . src/main/java/org/xwiki/officeimporter/internal/openoffice
asiri (SVN) wrote:
Author: asiri Date: 2009-04-29 09:52:15 +0200 (Wed, 29 Apr 2009) New Revision: 19183
Modified: platform/core/trunk/xwiki-officeimporter/pom.xml platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice/DefaultOpenOfficeServerManager.java Log: XWIKI-3711: Upgrade officeimporter to use jodconverter-3.0-beta-2
Could this port be taken from a configuration? I don't like magic numbers.
+ OfficeConnectionMode connectionMode = OfficeConnectionMode.socket(8100);
-- Sergiu Dumitriu http://purl.org/net/sergiu/
Hi, On Wed, Apr 29, 2009 at 2:59 PM, Sergiu Dumitriu <[email protected]> wrote:
asiri (SVN) wrote:
Author: asiri Date: 2009-04-29 09:52:15 +0200 (Wed, 29 Apr 2009) New Revision: 19183
Modified: platform/core/trunk/xwiki-officeimporter/pom.xml
platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice/DefaultOpenOfficeServerManager.java
Log: XWIKI-3711: Upgrade officeimporter to use jodconverter-3.0-beta-2
Could this port be taken from a configuration? I don't like magic numbers.
Yes. This was the default port used in jodconverter 3.0-beta-1 release and it was not configurable. With beta-2 release they have made it configurable along with few more configuration options (connection string etc.). For this issue I was focusing on upgrading our officeimporter to jodconverter beta-2 release, I will create new issues for adding additional configuration options. Thanks. - Asiri
participants (2)
-
Asiri Rathnayake -
Sergiu Dumitriu