[xwiki-devs] [Proposal] Replace OpenJS Keyboard JS with Keypress JS for handling keyboard shoirtcuts
Hi devs, We’re currently using http://www.openjs.com/scripts/events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example. For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case). I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful. See sequence combos for example. The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it. WDYT? Thanks -Vincent
+0 On Wed, Jul 26, 2017 at 10:50 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
-- Thomas Mortagne
+0 Thanks, Marius On Wed, Jul 26, 2017 at 11:50 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/ events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
+0 Thanks, Alex On Mon, Jul 31, 2017 at 11:19 AM, Marius Dumitru Florea < [email protected]> wrote:
+0
Thanks, Marius
On Wed, Jul 26, 2017 at 11:50 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/ events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
+1 Thanks, On 07/31/2017 10:27 AM, Alexandru Cotiuga wrote:
+0
Thanks, Alex
On Mon, Jul 31, 2017 at 11:19 AM, Marius Dumitru Florea < [email protected]> wrote:
+0
Thanks, Marius
On Wed, Jul 26, 2017 at 11:50 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/ events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
-- Clément Aubin Web Developer Intern @XWiki SAS [email protected] More about us at http://www.xwiki.com
+0 Thanks, Caty On Mon, Jul 31, 2017 at 12:08 PM, Clément Aubin <[email protected]> wrote:
+1
Thanks,
On 07/31/2017 10:27 AM, Alexandru Cotiuga wrote:
+0
Thanks, Alex
On Mon, Jul 31, 2017 at 11:19 AM, Marius Dumitru Florea < [email protected]> wrote:
+0
Thanks, Marius
On Wed, Jul 26, 2017 at 11:50 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/ events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
-- Clément Aubin Web Developer Intern @XWiki SAS [email protected] More about us at http://www.xwiki.com
Really a good idea to address this! So my +1. However, I think it would get more +1 if “see sequence combos for example” is made clear to me. My problem with the current keybinding is that it conflicts with things which I expect to work in each web-page. In particular cmd-G which I expect to be “find next” and which works on all websites I regularly use except XWikis. thanks in advance. Paul
On 26 Jul 2017, at 22:50, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
Maybe with the new library we can make cheat codes like "CTRL + X + W + i+ k+ i + D + e + v + T + e + a +m + R + o +x" in order to take over the wiki :) Thanks, Caty On Wed, Aug 2, 2017 at 8:11 AM, Paul Libbrecht <[email protected]> wrote:
Really a good idea to address this! So my +1.
However, I think it would get more +1 if “see sequence combos for example” is made clear to me. My problem with the current keybinding is that it conflicts with things which I expect to work in each web-page. In particular cmd-G which I expect to be “find next” and which works on all websites I regularly use except XWikis.
thanks in advance.
Paul
On 26 Jul 2017, at 22:50, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/ events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
This wasn’t a vote but here’s the result: 3 +1 and 4 +0. So @Clement, I think we should plan this now :) WDYT? Thanks -Vincent
On 26 Jul 2017, at 22:50, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
Hi, On 10/29/2017 11:56 AM, Vincent Massol wrote:
This wasn’t a vote but here’s the result: 3 +1 and 4 +0.
So @Clement, I think we should plan this now :) WDYT?
Yep, absolutely :) Just created XWIKI-14808 for this job. I'll try to give it a shot in the next weeks. Thanks, Clément
Thanks -Vincent
On 26 Jul 2017, at 22:50, Vincent Massol <[email protected]> wrote:
Hi devs,
We’re currently using http://www.openjs.com/scripts/events/keyboard_shortcuts/ but it has some limitations. Clement and I tried to find some unused combinations of keys that works on Mac and Unix and we couldn’t find any that worked with it. It also doesn’t support having combinations with several letters for example.
For example we could imagine having H+H+H for turning on/off hidden documents (as a developer key sequence since it’s not a user use case).
I’d like to propose using https://dmauro.github.io/Keypress/ which is under the Apache 2 license and that seems to work well on Mac and Unix and it’s very powerful.
See sequence combos for example.
The API look simple and nice and I don’t think it would be hard to continue support our data structure inside the “shortcuts” variable to make it work with it.
WDYT?
Thanks -Vincent
participants (8)
-
Alexandru Cotiuga -
Clément Aubin -
Clément Aubin -
Ecaterina Moraru (Valica) -
Marius Dumitru Florea -
Paul Libbrecht -
Thomas Mortagne -
Vincent Massol