[xwiki-devs] [VOTE] Make ComponentManager a component
Hi, I'd like to remove the usage of Composable and instead inject directly the ComponentManager. Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally). Here's my +1 Thanks -Vincent
+1 Vincent Massol wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Vincent Massol wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
++1, I never liked the Composable interface. -- Sergiu Dumitriu http://purl.org/net/sergiu/
On May 27, 2009, at 12:04 PM, Sergiu Dumitriu wrote:
Vincent Massol wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
++1, I never liked the Composable interface.
+1 -Fabio
+0 Vincent Massol wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-0 From what I can see, there is no special reason for doing this, but I'm not strongly against it, either. Vincent Massol wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On May 27, 2009, at 1:02 PM, Dan Miron wrote:
-0 From what I can see, there is no special reason for doing this, but I'm not strongly against it, either.
I had not mentioned the reasons since I thought they were pretty obvious: 1) Remove lines of code. It removes about 10 lines 2) Use a standard mechanism (dependency injection 3) Make it easier to implement different container manager adapters for our DI frameworks In addition, and less obvious, this is also a prereq for easily adding support for Events in ComponentManager. Thanks -Vincent
Vincent Massol wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
Here's my +1
Thanks -Vincent
+1 On Wed, May 27, 2009 at 3:01 PM, Vincent Massol <[email protected]> wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 On Wed, May 27, 2009 at 11:31, Vincent Massol <[email protected]> wrote:
Hi,
I'd like to remove the usage of Composable and instead inject directly the ComponentManager.
Implementation note: I'll create a component manager component wrapping ComponentManager (thus using Composable internally).
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
participants (8)
-
Asiri Rathnayake -
Dan Miron -
Fabio Mancinelli -
Jerome Velociter -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol