[xwiki-devs] [Proposal] Filesystem skin properties
Hi devs, I plan to introduce a skin.properties file at the root of each filesystem skin which will contain among other things the parent of this skin. The name of the property I propose "parent", when parent is set to empyt string it means not parent (i.e. it ends up directly in the WAR /templates or /resources folders). Yes I know we usually talk about "base skin" right now but I tough "parent" is more explicit when talking about inheritance (and the internal skin manager I'm working on is also using "parent" naming). Any tough ? If I don't get any reaction I will take that as a general +0 and commit it in master ;) -- Thomas Mortagne
Done. You still have time to complain until we release 6.4 final basically. On Tue, Nov 18, 2014 at 10:27 AM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
I plan to introduce a skin.properties file at the root of each filesystem skin which will contain among other things the parent of this skin.
The name of the property I propose "parent", when parent is set to empyt string it means not parent (i.e. it ends up directly in the WAR /templates or /resources folders). Yes I know we usually talk about "base skin" right now but I tough "parent" is more explicit when talking about inheritance (and the internal skin manager I'm working on is also using "parent" naming).
Any tough ?
If I don't get any reaction I will take that as a general +0 and commit it in master ;)
-- Thomas Mortagne
-- Thomas Mortagne
+1, great feature! Thanks, Marius On Tue, Nov 18, 2014 at 11:27 AM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
I plan to introduce a skin.properties file at the root of each filesystem skin which will contain among other things the parent of this skin.
The name of the property I propose "parent", when parent is set to empyt string it means not parent (i.e. it ends up directly in the WAR /templates or /resources folders). Yes I know we usually talk about "base skin" right now but I tough "parent" is more explicit when talking about inheritance (and the internal skin manager I'm working on is also using "parent" naming).
Any tough ?
If I don't get any reaction I will take that as a general +0 and commit it in master ;)
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Good thing! 2014-11-19 9:07 GMT+01:00 Marius Dumitru Florea < [email protected]>:
+1, great feature!
Thanks, Marius
On Tue, Nov 18, 2014 at 11:27 AM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
I plan to introduce a skin.properties file at the root of each filesystem skin which will contain among other things the parent of this skin.
The name of the property I propose "parent", when parent is set to empyt string it means not parent (i.e. it ends up directly in the WAR /templates or /resources folders). Yes I know we usually talk about "base skin" right now but I tough "parent" is more explicit when talking about inheritance (and the internal skin manager I'm working on is also using "parent" naming).
Any tough ?
If I don't get any reaction I will take that as a general +0 and commit it in master ;)
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
participants (3)
-
Guillaume "Louis-Marie" Delhumeau -
Marius Dumitru Florea -
Thomas Mortagne