Re: [xwiki-devs] [xwiki-notifications] r13944 - sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/officeimporter/transformer
Hi Asiri, On Nov 4, 2008, at 7:06 AM, asiri (SVN) wrote:
Author: asiri Date: 2008-11-04 07:06:01 +0100 (Tue, 04 Nov 2008) New Revision: 13944
Modified: sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ plugin/officeimporter/transformer/HtmlToXWikiTwoZeroTransformer.java Log: JIRA : http://jira.xwiki.org/jira/browse/XAOFFICE-1
Fixes lists support. <p> tags inside <li> tags are not rendered properly in xwiki 2.0. Rip them off and it works fine.
I don't think this is correct. Either it's valid XHTML to have <P> inside <LI> and in which case it's a bug of the XHTML parser or it's not valid and it's a job for the HTML cleaner. In both cases I don't think this is related to office imports. It's really import that whenever you need a transformation/cleaning that you decide where it should go: * in the XHTML parser * in the HTML cleaner * in the office importer Thanks -Vincent
On Nov 4, 2008, at 8:42 AM, Vincent Massol wrote:
Hi Asiri,
On Nov 4, 2008, at 7:06 AM, asiri (SVN) wrote:
Author: asiri Date: 2008-11-04 07:06:01 +0100 (Tue, 04 Nov 2008) New Revision: 13944
Modified: sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ plugin/officeimporter/transformer/HtmlToXWikiTwoZeroTransformer.java Log: JIRA : http://jira.xwiki.org/jira/browse/XAOFFICE-1
Fixes lists support. <p> tags inside <li> tags are not rendered properly in xwiki 2.0. Rip them off and it works fine.
I don't think this is correct. Either it's valid XHTML to have <P> inside <LI> and in which case it's a bug of the XHTML parser or it's not valid and it's a job for the HTML cleaner.
In both cases I don't think this is related to office imports.
It's really import that whenever you need a transformation/cleaning that you decide where it should go: * in the XHTML parser * in the HTML cleaner * in the office importer
This link http://learningforlife.fsu.edu/webmaster/references/xhtml/tags/list/li.cfm indicates that <P> is a valid child element of <LI> so the XHTML parser must support this. Please file a jira issue if that's not the case (with an example to reproduce) and I'll fix it. Thanks -Vincent
On Tue, Nov 4, 2008 at 1:14 PM, Vincent Massol <[email protected]> wrote:
On Nov 4, 2008, at 8:42 AM, Vincent Massol wrote:
Hi Asiri,
On Nov 4, 2008, at 7:06 AM, asiri (SVN) wrote:
Author: asiri Date: 2008-11-04 07:06:01 +0100 (Tue, 04 Nov 2008) New Revision: 13944
Modified: sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ plugin/officeimporter/transformer/HtmlToXWikiTwoZeroTransformer.java Log: JIRA : http://jira.xwiki.org/jira/browse/XAOFFICE-1
Fixes lists support. <p> tags inside <li> tags are not rendered properly in xwiki 2.0. Rip them off and it works fine.
I don't think this is correct. Either it's valid XHTML to have <P> inside <LI> and in which case it's a bug of the XHTML parser or it's not valid and it's a job for the HTML cleaner.
In both cases I don't think this is related to office imports.
It's really import that whenever you need a transformation/cleaning that you decide where it should go: * in the XHTML parser * in the HTML cleaner * in the office importer
This link http://learningforlife.fsu.edu/webmaster/references/xhtml/tags/list/li.cfm indicates that <P> is a valid child element of <LI> so the XHTML parser must support this. Please file a jira issue if that's not the case (with an example to reproduce) and I'll fix it.
Thanks. I'll file a Jira issue. - Asiri
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Asiri Rathnayake -
Vincent Massol