[xwiki-devs] Default size for upload_maxsize?
Hi, Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value? What could be the a better value? That's a hard question but I'd say 30MB should be fine. WDYT? Thanks -Vincent
30 MB seems indeed a better choice. Will you add the property to the XWikiPreferences class ? Because one of the problenms was that when you started xwiki with an empty database, and wanted to reload a backup of your wiki contents, you could not add the property to the class in the class editor - and that is the time when you need it the most, since you want to import the XAR of your wiki, which might easily be more than the max upload size (if users had uploaded a lot of attachments). On 11/22/07, Vincent Massol <[email protected]> wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vivien MAURICE Elève Ingénieur Informatique et Gestion, Polytech'Montpellier (ISIM) E-mail : [email protected] Tél. : 0046 7 62 33 20 46 Skype : jean.vivien
Hi, For the property issue, it would indeed be great to have it by default, and to increase the default size. Also, there are two tricks you can use to add it when you have an empty wiki : the first one would consist of importing a standard XAR before importing your actual wiki, which would allows you to edit the class with the editor. The second one would be to use the "propadd" URL action : hit something like .../xwiki/bin/propadd/XWiki/XWikiPreferences?propname=maxsize_upload&proptype=com.xpn.xwiki.objects.classes.NumberClass inside your browser. I agree, it's not really convenient, but it can help on such cases where you are stuck. Jerome.
30 MB seems indeed a better choice. Will you add the property to the XWikiPreferences class ? Because one of the problenms was that when you started xwiki with an empty database, and wanted to reload a backup of your wiki contents, you could not add the property to the class in the class editor - and that is the time when you need it the most, since you want to import the XAR of your wiki, which might easily be more than the max upload size (if users had uploaded a lot of attachments).
On 11/22/07, Vincent Massol <[email protected]> wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vivien MAURICE Elève Ingénieur Informatique et Gestion, Polytech'Montpellier (ISIM) E-mail : [email protected] Tél. : 0046 7 62 33 20 46 Skype : jean.vivien _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Nov 22, 2007, at 10:36 AM, jvivien.m2 jvivien.m2 wrote:
30 MB seems indeed a better choice. Will you add the property to the XWikiPreferences class ?
This is done already. All the remains is to agree on a maxsize default value. -Vincent
Because one of the problenms was that when you started xwiki with an empty database, and wanted to reload a backup of your wiki contents, you could not add the property to the class in the class editor - and that is the time when you need it the most, since you want to import the XAR of your wiki, which might easily be more than the max upload size (if users had uploaded a lot of attachments).
On 11/22/07, Vincent Massol <[email protected]> wrote: Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
sorry guys, i dont get it yet... why not add the property to the default list of properties in the XWikipreferences class, directly ? i agree with you on the default value, but i dont see why it wouldnt be possible to have upload_maxsize as one of the properties which are readily accessible, when you edit the XWikiPreferences object ? If this would have to be coded in the xwiki Java source code, then maybe it could be added to the next version :-) If its not too much work for you (i dont think it is actually, and that s why i ask about it) On 11/22/07, Vincent Massol <[email protected]> wrote:
On Nov 22, 2007, at 10:36 AM, jvivien.m2 jvivien.m2 wrote:
30 MB seems indeed a better choice. Will you add the property to the XWikiPreferences class ?
This is done already.
All the remains is to agree on a maxsize default value.
-Vincent
Because one of the problenms was that when you started xwiki with an empty database, and wanted to reload a backup of your wiki contents, you could not add the property to the class in the class editor - and that is the time when you need it the most, since you want to import the XAR of your wiki, which might easily be more than the max upload size (if users had uploaded a lot of attachments).
On 11/22/07, Vincent Massol <[email protected]> wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vivien MAURICE Elève Ingénieur Informatique et Gestion, Polytech'Montpellier (ISIM) E-mail : [email protected] Tél. : 0046 7 62 33 20 46 Skype : jean.vivien
Actually, what Vincent said is that he just done the job and commited it, so next XWiki release will have that upload_maxsize parameter available by default in XWiki.XWikiPreferences. My email was a bit misleading, I just wanted to expose ways of getting this preference (for example for current versions, where it is not set by default). For the default size, the question is, is there any constraint that prevent us to have a large value (let's say 100MB+) ? If we don't consider this param, the limiting factor for big imports is heap memory ? Jérôme.
sorry guys, i dont get it yet... why not add the property to the default list of properties in the XWikipreferences class, directly ? i agree with you on the default value, but i dont see why it wouldnt be possible to have upload_maxsize as one of the properties which are readily accessible, when you edit the XWikiPreferences object ? If this would have to be coded in the xwiki Java source code, then maybe it could be added to the next version :-) If its not too much work for you (i dont think it is actually, and that s why i ask about it)
On 11/22/07, Vincent Massol <[email protected]> wrote:
On Nov 22, 2007, at 10:36 AM, jvivien.m2 jvivien.m2 wrote:
30 MB seems indeed a better choice. Will you add the property to the XWikiPreferences class ?
This is done already.
All the remains is to agree on a maxsize default value.
-Vincent
Because one of the problenms was that when you started xwiki with an empty database, and wanted to reload a backup of your wiki contents, you could not add the property to the class in the class editor - and that is the time when you need it the most, since you want to import the XAR of your wiki, which might easily be more than the max upload size (if users had uploaded a lot of attachments).
On 11/22/07, Vincent Massol <[email protected]> wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vivien MAURICE Elève Ingénieur Informatique et Gestion, Polytech'Montpellier (ISIM) E-mail : [email protected] Tél. : 0046 7 62 33 20 46 Skype : jean.vivien _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Nov 22, 2007, at 3:06 PM, Jerome Velociter wrote:
Actually, what Vincent said is that he just done the job and commited it, so next XWiki release will have that upload_maxsize parameter available by default in XWiki.XWikiPreferences. My email was a bit misleading, I just wanted to expose ways of getting this preference (for example for current versions, where it is not set by default).
For the default size, the question is, is there any constraint that prevent us to have a large value (let's say 100MB+) ? If we don't consider this param, the limiting factor for big imports is heap memory ?
Yes you're right for the limiting factor. I think we should choose a value that allows to attach typical documents: word, ppt, excel, etc. These are typically < 10 MB anyway (and most people also want to exchange them by email so there's the typical limit of < 10 MB). I don't think we should size it for backups since there's no cap for this. For example for xwiki.org the XAR size must be close to 600MB I think and it can easily grow much bigger. The only downside I can think for large values are: * heap size, people will get OOM exceptions * time to upload * time to expand the xar when you click on it in the import page (we need to change that since for large xars it takes at least 10 seconds before showing anything) * potential database slowdown if there are large files in them BTW Mysql has a default 1MB max. I wonder why they have this default limitation. Might be interesting to understand. Any other opinion, idea? Thanks -Vincent
sorry guys, i dont get it yet... why not add the property to the default list of properties in the XWikipreferences class, directly ? i agree with you on the default value, but i dont see why it wouldnt be possible to have upload_maxsize as one of the properties which are readily accessible, when you edit the XWikiPreferences object ? If this would have to be coded in the xwiki Java source code, then maybe it could be added to the next version :-) If its not too much work for you (i dont think it is actually, and that s why i ask about it)
On 11/22/07, Vincent Massol <[email protected]> wrote:
On Nov 22, 2007, at 10:36 AM, jvivien.m2 jvivien.m2 wrote:
30 MB seems indeed a better choice. Will you add the property to the XWikiPreferences class ?
This is done already.
All the remains is to agree on a maxsize default value.
-Vincent
Because one of the problenms was that when you started xwiki with an empty database, and wanted to reload a backup of your wiki contents, you could not add the property to the class in the class editor - and that is the time when you need it the most, since you want to import the XAR of your wiki, which might easily be more than the max upload size (if users had uploaded a lot of attachments).
On 11/22/07, Vincent Massol <[email protected]> wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vivien MAURICE Elève Ingénieur Informatique et Gestion, Polytech'Montpellier (ISIM) E-mail : [email protected] Tél. : 0046 7 62 33 20 46 Skype : jean.vivien _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi No idea guys... We can have 30 MB. regards Arvind On 22/11/2007, Vincent Massol <[email protected]> wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Vincent Massol wrote:
Hi,
Several users are saying that 10MB is too low a default value. I think I agree with them. Now I can't think of a downside for increasing it to a higher value. Is there any potential issue increasing it by default to a higher value?
What could be the a better value? That's a hard question but I'd say 30MB should be fine.
WDYT?
Thanks -Vincent
Let's make it a round number: 32M Sergiu
participants (5)
-
Arvind -
Jerome Velociter -
jvivien.m2 jvivien.m2 -
Sergiu Dumitriu -
Vincent Massol