[xwiki-devs] XECLIPSE-21 : [actually - space description ignored in back-end xmlrpc]
Hi All, XECLIPSE-21 <http://jira.xwiki.org/jira/browse/XECLIPSE-21> complains that space description set on the space creation page (on xeclipse) is not added to the space's home page. But the actual problem is that addSpace() xmlrpc intentionally ignores space description . I think catalin worked on this and he has mentioned about this on the method comments. Anyway, i'm attaching a patch with this mail that would fix it. Catalin, is there a particular reason to ignore the space description ? Thanks. - Asiri
Hi Vincent, I had a discussion with Catalin about this issue and according to him XWiki does not have a notion of a space description. How this situation to be handled ? 1. Froget about space description in xeclipse ? 2. Call it initial HomePage content and add this description to space's home page at the back-end xmlrpc. <-- bad since we should not be modifying xmlrpc interface for every little problem. Any ideas ? Thanks. - Asiri On 9/6/07, Asiri Rathnayake <[email protected]> wrote:
Hi All,
XECLIPSE-21 <http://jira.xwiki.org/jira/browse/XECLIPSE-21> complains that space description set on the space creation page (on xeclipse) is not added to the space's home page. But the actual problem is that addSpace() xmlrpc intentionally ignores space description . I think catalin worked on this and he has mentioned about this on the method comments. Anyway, i'm attaching a patch with this mail that would fix it. Catalin, is there a particular reason to ignore the space description ?
Thanks.
- Asiri
Hi Asiri, On Sep 7, 2007, at 8:06 PM, Asiri Rathnayake wrote:
Hi Vincent,
I had a discussion with Catalin about this issue and according to him XWiki does not have a notion of a space description. How this situation to be handled ?
1. Froget about space description in xeclipse ?
Nope :) When you create a space you actually create a WebHome document. So the space "description" is actually the WebHome content. WDYT?
2. Call it initial HomePage content and add this description to space's home page at the back-end xmlrpc. <-- bad since we should not be modifying xmlrpc interface for every little problem.
Any ideas ?
Yes, see above. Thanks -Vincent
On 9/6/07, Asiri Rathnayake <[email protected]> wrote: Hi All,
XECLIPSE-21 complains that space description set on the space creation page (on xeclipse) is not added to the space's home page. But the actual problem is that addSpace() xmlrpc intentionally ignores space description . I think catalin worked on this and he has mentioned about this on the method comments. Anyway, i'm attaching a patch with this mail that would fix it. Catalin, is there a particular reason to ignore the space description ?
Thanks.
- Asiri
Hi Vincent, On 9/7/07, Vincent Massol <[email protected]> wrote:
Hi Asiri,
On Sep 7, 2007, at 8:06 PM, Asiri Rathnayake wrote: Hi Vincent,
I had a discussion with Catalin about this issue and according to him XWiki does not have a notion of a space description. How this situation to be handled ?
1. Froget about space description in xeclipse ?
Nope :)
If you think it's worth it then add this feature to xwiki. Trying to fake it won't do.
When you create a space you actually create a WebHome document. So the space "description" is actually the WebHome content.
WDYT?
[snip] This is not a solution (to what I consider a non-problem ... what's the purpose of the description anyway?). Nobody will expect that changing the WebHome document will also change the space description. Catalin
2. Call it initial HomePage content and add this description to space's home page at the back-end xmlrpc. <-- bad since we should not be modifying xmlrpc interface for every little problem.
Any ideas ?
Yes, see above.
Thanks -Vincent
On 9/6/07, Asiri Rathnayake <[email protected]> wrote:
Hi All,
XECLIPSE-21 complains that space description set on the space creation page (on xeclipse) is not added to the space's home page. But the actual problem is that addSpace() xmlrpc intentionally ignores space description . I think catalin worked on this and he has mentioned about this on the method comments. Anyway, i'm attaching a patch with this mail that would fix it. Catalin, is there a particular reason to ignore the space description ?
Thanks.
- Asiri
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Correcting myself On 9/7/07, Catalin Hritcu <[email protected]> wrote:
Hi Vincent,
On 9/7/07, Vincent Massol <[email protected]> wrote:
Hi Asiri,
On Sep 7, 2007, at 8:06 PM, Asiri Rathnayake wrote: Hi Vincent,
I had a discussion with Catalin about this issue and according to him XWiki does not have a notion of a space description. How this situation to be handled ?
1. Froget about space description in xeclipse ?
Nope :)
If you think it's worth it then add this feature to xwiki. Trying to fake it won't do.
When you create a space you actually create a WebHome document. So the space "description" is actually the WebHome content.
WDYT?
[snip]
This is not a solution (to what I consider a non-problem ... what's the purpose of the description anyway?). Nobody will expect that changing the WebHome document will also change the space description.
I meant the opposite, changing the space description should not (under any circumstance!) change the content of WebHome. This would be just stupid as the WebHome page is usually the most important page in a space. Catalin
2. Call it initial HomePage content and add this description to space's home page at the back-end xmlrpc. <-- bad since we should not be modifying xmlrpc interface for every little problem.
Any ideas ?
Yes, see above.
Thanks -Vincent
On 9/6/07, Asiri Rathnayake <[email protected]> wrote:
Hi All,
XECLIPSE-21 complains that space description set on the space creation page (on xeclipse) is not added to the space's home page. But the actual problem is that addSpace() xmlrpc intentionally ignores space description . I think catalin worked on this and he has mentioned about this on the method comments. Anyway, i'm attaching a patch with this mail that would fix it. Catalin, is there a particular reason to ignore the space description ?
Thanks.
- Asiri
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi All, On 9/8/07, Catalin Hritcu <[email protected]> wrote:
Correcting myself
On 9/7/07, Catalin Hritcu <[email protected]> wrote:
Hi Vincent,
On 9/7/07, Vincent Massol <[email protected]> wrote:
Hi Asiri,
On Sep 7, 2007, at 8:06 PM, Asiri Rathnayake wrote: Hi Vincent,
I had a discussion with Catalin about this issue and according to him XWiki does not have a notion of a space description. How this situation to be handled ?
1. Froget about space description in xeclipse ?
Nope :)
If you think it's worth it then add this feature to xwiki. Trying to fake it won't do.
When you create a space you actually create a WebHome document. So the space "description" is actually the WebHome content.
WDYT?
[snip]
This is not a solution (to what I consider a non-problem ... what's the purpose of the description anyway?). Nobody will expect that changing the WebHome document will also change the space description.
I meant the opposite, changing the space description should not (under any circumstance!)
In my POV, there are no hard & fast rules when it comes to this sort of issues. We always have to make decisions leading to trade-offs sometimes. If there is no such thing as a description for a space and if creating a space actually means creating a WebHome document, setting space description as WebHome's initial content (only in creation time) will be acceptable. But this doesn't mean we should change WebHome's content every time the space description is altered (and there is no such thing as a space description to be altered). We can document this in xmlrpc saying space description will be added as WebHome's initial content. Only change in xeclipse will be to re-label "Description" field as "WebHome content".... This is just an opinion. - Asiri change the content of WebHome. This would be just
stupid as the WebHome page is usually the most important page in a space.
Catalin
2. Call it initial HomePage content and add this description to
space's home
page at the back-end xmlrpc. <-- bad since we should not be modifying xmlrpc interface for every little problem.
Any ideas ?
Yes, see above.
Thanks -Vincent
On 9/6/07, Asiri Rathnayake <[email protected]> wrote:
Hi All,
XECLIPSE-21 complains that space description set on the space creation page (on xeclipse) is not added to the space's home page. But the actual problem is that addSpace() xmlrpc intentionally ignores space description . I think catalin worked on this and he has mentioned about this on the method comments. Anyway, i'm attaching a patch with this mail that would fix it. Catalin, is there a particular reason to ignore the space description ?
Thanks.
- Asiri
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (3)
-
Asiri Rathnayake -
Catalin Hritcu -
Vincent Massol