Hi all, I did a small refactoring in the REST module which consisted in isolating the JAXB model classes in a separate module. This allows client to use JAXB classes for retrieving XML representations without dragging in all the core dependencies. The refactoring consisted in creating an xwiki-rest-model module in core, moving some files, and update the pom.xml's to make things compile. Maybe it's risky to commit it now, but if you are ok everything's ready. I include a diff so that you can check what it looks like. -Fabio
On Mon, Jul 5, 2010 at 19:03, Fabio Mancinelli <[email protected]> wrote:
Hi all,
I did a small refactoring in the REST module which consisted in isolating the JAXB model classes in a separate module.
This allows client to use JAXB classes for retrieving XML representations without dragging in all the core dependencies.
The refactoring consisted in creating an xwiki-rest-model module in core, moving some files, and update the pom.xml's to make things compile.
Maybe it's risky to commit it now, but if you are ok everything's ready. I include a diff so that you can check what it looks like.
Big +1 for doing it before 2.4 final.
-Fabio
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Hi Fabio, I think as soon as possible as good, and RC phase is a good moment to do it. +1 Happy refactoring, Anca On 07/05/2010 08:03 PM, Fabio Mancinelli wrote:
Hi all,
I did a small refactoring in the REST module which consisted in isolating the JAXB model classes in a separate module.
This allows client to use JAXB classes for retrieving XML representations without dragging in all the core dependencies.
The refactoring consisted in creating an xwiki-rest-model module in core, moving some files, and update the pom.xml's to make things compile.
Maybe it's risky to commit it now, but if you are ok everything's ready. I include a diff so that you can check what it looks like.
-Fabio
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Jul 5, 2010, at 10:29 PM, Anca Luca wrote:
Hi Fabio,
I think as soon as possible as good, and RC phase is a good moment to do it.
I don't think RC is a good phase (it's a stabilization phase after all) but if Fabio judges it's safe I'm fine too (provided he's ok to fix quickly any issue that may arise. If he doesn't need it urgently then better wait for 2.5M1. Thanks -Vincent
+1
Happy refactoring, Anca
On 07/05/2010 08:03 PM, Fabio Mancinelli wrote:
Hi all,
I did a small refactoring in the REST module which consisted in isolating the JAXB model classes in a separate module.
This allows client to use JAXB classes for retrieving XML representations without dragging in all the core dependencies.
The refactoring consisted in creating an xwiki-rest-model module in core, moving some files, and update the pom.xml's to make things compile.
Maybe it's risky to commit it now, but if you are ok everything's ready. I include a diff so that you can check what it looks like.
-Fabio
On 07/05/2010 10:34 PM, Vincent Massol wrote:
On Jul 5, 2010, at 10:29 PM, Anca Luca wrote:
Hi Fabio,
I think as soon as possible as good, and RC phase is a good moment to do it.
I don't think RC is a good phase (it's a stabilization phase after all) but if Fabio judges it's safe I'm fine too (provided he's ok to fix quickly any issue that may arise. If he doesn't need it urgently then better wait for 2.5M1.
I actually don't need it urgently but since people started using the REST Api (see previous messages in the ML) I thought it was a good thing to do and, anyway, it's something that has to be done. Concerning the risk, I didn't touch any .java code so it should be pretty safe (I just moved the generation logic for the model in a separate module, that's all) What can be discussed it's just the name and the location of the module. I used xwiki-rest-model in core. If you are fine with that I can commit the changes. -Fabio
On Tue, Jul 6, 2010 at 09:42, Fabio Mancinelli <[email protected]> wrote:
On 07/05/2010 10:34 PM, Vincent Massol wrote:
On Jul 5, 2010, at 10:29 PM, Anca Luca wrote:
Hi Fabio,
I think as soon as possible as good, and RC phase is a good moment to do it.
I don't think RC is a good phase (it's a stabilization phase after all) but if Fabio judges it's safe I'm fine too (provided he's ok to fix quickly any issue that may arise. If he doesn't need it urgently then better wait for 2.5M1.
I actually don't need it urgently but since people started using the REST Api (see previous messages in the ML) I thought it was a good thing to do and, anyway, it's something that has to be done.
Concerning the risk, I didn't touch any .java code so it should be pretty safe (I just moved the generation logic for the model in a separate module, that's all)
What can be discussed it's just the name and the location of the module. I used xwiki-rest-model in core. If you are fine with that I can commit the changes.
xwiki-rest-model seems the right name yes.
-Fabio
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
participants (4)
-
Anca Luca -
Fabio Mancinelli -
Thomas Mortagne -
Vincent Massol