On Thu, Nov 18, 2010 at 19:06, Anca Luca <[email protected]> wrote:

Hi devs,

On 11/18/2010 07:33 PM, Jerome Velociter wrote:

...

Hi devs,

+@Component("register-macros-on-import")

I inspired this from the other listener I wrote, for the annotations maintainer, which is also separated with dash (I don't remember why I separated that with dash -- I just searched in the other renderers couldn't find any other usages of dash...).

However I also found: "observation.remote" as a hint "wikimacrolistener" and "WikiMacroExecutionEventListener" so there is no rule whatsoever.

Or is it?

Indeed no rule has really been defined.

Thanks, Anca

...

+public class RegisterMacrosOnImportListener extends AbstractLogEnabled

...

implements EventListener

Question : do we have a rule for component hints naming ? I have the feeling we are mixing uppercases and dashes for separating words. We should chose one and stick to it IMO. I'd go for uppercases.

WDYT ?

Jerome. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne