Glyphicon is a very small set so it cannot cover all the use cases Silk had. So having Font Awesome to replace it it's the good choice. Especially since Font Awesome is very popular and is continuously expanding, see Font Awesome 5. On Mon, Oct 24, 2016 at 3:39 PM, Guillaume Delhumeau < [email protected]> wrote:

Hello there.

Flamingo is a skin based on Bootstrap, and this framework offers a free but reduced set of icons [1] coming from Glyphicons.com [2].

For this reason, when I started the implementation of Flamingo, I used the free Glyphicons from Bootstrap.

A few months later, we introduced the Icon Theme Application [3], in order to replace our Silk icons [4] by more accurate ones, depending on the configuration of the wiki.

Unfortunately, the icons provided by Bootstrap were not a good candidate to replace Silk, because a lot of icons were missing. Instead, we have decided to use Font Awesome [5], which looks more like Glyphicons.

However, we haven't changed Flamingo to drop glyphicon, so we have an inconsistency between what we propose to developers via the Icon Theme Application, and what we have in the skin. It means a developer cannot, using our best practices, re-use the same icons that the normal UI.

So the only option I see is to use the Icon Theme Application in Flamingo too. We have an issue for this [6].

But it means: - Flamingo won't look good if the Font Awesome Theme is not installed on the wiki

We can declare a dependency for Flamingo on Icon Themes, and set Font Awesome Theme as default for a particular version.

- It's a matter of taste or habit, but I think Font Awesome does not look as good than Glyphicons in the skin. See: -- http://jira.xwiki.org/secure/attachment/33143/mockup.png -- http://jira.xwiki.org/secure/attachment/33144/mockup-drawer.png

I would suggest a couple of things regarding to these screenshots (in order to be close to the Glyphicon usage and general standards) 1. Using http://fontawesome.io/icon/ellipsis-v/ instead of http://fontawesome.io/icon/caret-down/ for #tmMoreActions 2. Using http://fontawesome.io/icon/plus/ instead of http://fontawesome.io/icon/plus-circle/ for #tmCreate The only change would be some different styling for the Pencil, which I think they are manageable.

- Some Velocity macros [7] (that might be used by extensions) expect to work with Glyphicons. By changing this we create a breaking change.

Regarding the menus_macros.vm example, since this is also in Flamingo, it means we just need to change and call Icon Themes service.

I am not satisfied with the first results. It may be improved, but keep in mind that every changes that we made in the XWiki Icon Set affect all Icon Themes (Font Awesome and Silk).

What do you think ?

I'm +1 to replace all Glyphicons calls with the Icon Theme. This way we could include other icon sets in the future. Thanks, Caty

Thanks, Guillaume

[1] http://getbootstrap.com/components/#glyphicons [2] http://glyphicons.com/ [3] http://extensions.xwiki.org/xwiki/bin/view/Extension/Icon+ Theme+Application [4] http://www.famfamfam.com/lab/icons/silk/ [5] http://fontawesome.io/ [6] http://jira.xwiki.org/browse/XWIKI-12595 [7] For example https://github.com/xwiki/xwiki-platform/blob/ 76ff57ec6a6fca48bc5f3f563f575b41efce0114/xwiki-platform- core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/ xwiki-platform-flamingo-skin-resources/src/main/resources/ flamingo/menus_macros.vm#L73-L73 used by http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/ Edit+Actions

-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs