[xwiki-devs] [VOTE] Get rid of Portlet API in oldcore
Hi guys, oldcore contains references to Portlet API 1.0 in various API. There is several issues: 1) Thoses API are useless since most of the code expect a servlet and would never work inside a Portlet so that make this API totally useless 2) It's a real pain for things like https://github.com/xwiki-contrib/sandbox/tree/master/xwiki-portlet (a portlet proxy/translator in front of XWiki) since it makes impossible to use Portlet API 2.0 (we had to create our own special branch were we remove all reference to 1.0 API in oldcore) 3) XWiki cannot work without the portlet jar even when used as Servlet which is quite ugly Since we are starting a new major version and it's a breaking change I propose to do it now. Here is my +1 -- Thomas Mortagne
+1 On Thu, Feb 7, 2013 at 4:48 PM, Thomas Mortagne <[email protected]>wrote:
Hi guys, oldcore contains references to Portlet API 1.0 in various API.
There is several issues: 1) Thoses API are useless since most of the code expect a servlet and would never work inside a Portlet so that make this API totally useless 2) It's a real pain for things like https://github.com/xwiki-contrib/sandbox/tree/master/xwiki-portlet (a portlet proxy/translator in front of XWiki) since it makes impossible to use Portlet API 2.0 (we had to create our own special branch were we remove all reference to 1.0 API in oldcore) 3) XWiki cannot work without the portlet jar even when used as Servlet which is quite ugly
Since we are starting a new major version and it's a breaking change I propose to do it now.
Here is my +1 -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
On Feb 7, 2013, at 4:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi guys, oldcore contains references to Portlet API 1.0 in various API.
There is several issues: 1) Thoses API are useless since most of the code expect a servlet and would never work inside a Portlet so that make this API totally useless 2) It's a real pain for things like https://github.com/xwiki-contrib/sandbox/tree/master/xwiki-portlet (a portlet proxy/translator in front of XWiki) since it makes impossible to use Portlet API 2.0 (we had to create our own special branch were we remove all reference to 1.0 API in oldcore) 3) XWiki cannot work without the portlet jar even when used as Servlet which is quite ugly
Since we are starting a new major version and it's a breaking change I propose to do it now.
Here is my +1
+1 in general. Would be nice to see which api we're going to change though. Thanks -Vincent
On Thu, Feb 7, 2013 at 6:33 PM, Vincent Massol <[email protected]> wrote:
On Feb 7, 2013, at 4:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi guys, oldcore contains references to Portlet API 1.0 in various API.
There is several issues: 1) Thoses API are useless since most of the code expect a servlet and would never work inside a Portlet so that make this API totally useless 2) It's a real pain for things like https://github.com/xwiki-contrib/sandbox/tree/master/xwiki-portlet (a portlet proxy/translator in front of XWiki) since it makes impossible to use Portlet API 2.0 (we had to create our own special branch were we remove all reference to 1.0 API in oldcore) 3) XWiki cannot work without the portlet jar even when used as Servlet which is quite ugly
Since we are starting a new major version and it's a breaking change I propose to do it now.
Here is my +1
+1 in general.
Would be nice to see which api we're going to change though.
See https://github.com/xwiki/xwiki-platform/commit/805c5228f58be87506bf91e5bc73a... and https://github.com/xwiki/xwiki-platform/commit/d7527802d598b062e8b61433a84ea... Thanks, Marius
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
BIG + 1 :) Thanks, Marius On Thu, Feb 7, 2013 at 5:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi guys, oldcore contains references to Portlet API 1.0 in various API.
There is several issues: 1) Thoses API are useless since most of the code expect a servlet and would never work inside a Portlet so that make this API totally useless 2) It's a real pain for things like https://github.com/xwiki-contrib/sandbox/tree/master/xwiki-portlet (a portlet proxy/translator in front of XWiki) since it makes impossible to use Portlet API 2.0 (we had to create our own special branch were we remove all reference to 1.0 API in oldcore) 3) XWiki cannot work without the portlet jar even when used as Servlet which is quite ugly
Since we are starting a new major version and it's a breaking change I propose to do it now.
Here is my +1 -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Nobody seems to be against it, done. On Thu, Feb 7, 2013 at 4:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi guys, oldcore contains references to Portlet API 1.0 in various API.
There is several issues: 1) Thoses API are useless since most of the code expect a servlet and would never work inside a Portlet so that make this API totally useless 2) It's a real pain for things like https://github.com/xwiki-contrib/sandbox/tree/master/xwiki-portlet (a portlet proxy/translator in front of XWiki) since it makes impossible to use Portlet API 2.0 (we had to create our own special branch were we remove all reference to 1.0 API in oldcore) 3) XWiki cannot work without the portlet jar even when used as Servlet which is quite ugly
Since we are starting a new major version and it's a breaking change I propose to do it now.
Here is my +1 -- Thomas Mortagne
-- Thomas Mortagne
participants (4)
-
Denis Gervalle -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol