Re: [xwiki-devs] [xwiki-notifications] r33714 - enterprise/trunk/wiki/src/main/resources/ColorThemes
On 12/28/2010 01:22 PM, evalica (SVN) wrote:
Author: evalica Date: 2010-12-28 13:22:42 +0100 (Tue, 28 Dec 2010) New Revision: 33714
Modified: enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeClass.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeTemplate.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/DefaultColorTheme.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/WizardPropertyMapping.xml Log: XE-796: Customizable "Add" menu entry from the Color Theme Wizard
Modified: enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml =================================================================== --- enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml 2010-12-28 12:18:23 UTC (rev 33713) +++ enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml 2010-12-28 12:22:42 UTC (rev 33714) @@ -1431,6 +1434,7 @@ <div #elementMetaData('mainmenu')> <div> $msg.get('xe.themes.colors.wizard.mainMenu')
I think it would be better to use a different text for this one, since it's supposed to be used only for the Add entry:
+<span #elementMetaData('menuaddentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#$msg.get('core.menu.create')</span> <span #elementMetaData('menuentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#1</span> <span #elementMetaData('menuentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#2</span> </div>
-- Sergiu Dumitriu http://purl.org/net/sergiu/
On Tue, Dec 28, 2010 at 15:02, Sergiu Dumitriu <[email protected]> wrote:
On 12/28/2010 01:22 PM, evalica (SVN) wrote:
Author: evalica Date: 2010-12-28 13:22:42 +0100 (Tue, 28 Dec 2010) New Revision: 33714
Modified:
enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeClass.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeTemplate.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/DefaultColorTheme.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/WizardPropertyMapping.xml
Log: XE-796: Customizable "Add" menu entry from the Color Theme Wizard
Modified: enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml =================================================================== --- enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml 2010-12-28 12:18:23 UTC (rev 33713) +++ enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml 2010-12-28 12:22:42 UTC (rev 33714) @@ -1431,6 +1434,7 @@ <div #elementMetaData('mainmenu')> <div> $msg.get('xe.themes.colors.wizard.mainMenu')
I think it would be better to use a different text for this one, since it's supposed to be used only for the Add entry:
+<span #elementMetaData('menuaddentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#$msg.get('core.menu.create')</span> <span #elementMetaData('menuentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#1</span> <span #elementMetaData('menuentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#2</span> </div>
I kind of like it like this and is consistent, making a clear separation between what is entry or not "Main Menu Entry#Add Entry#1 Entry#2" see http://jira.xwiki.org/jira/secure/attachment/18333/AddCustomization.png Thanks, Caty
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 12/28/2010 02:16 PM, Ecaterina Moraru (Valica) wrote:
On Tue, Dec 28, 2010 at 15:02, Sergiu Dumitriu<[email protected]> wrote:
On 12/28/2010 01:22 PM, evalica (SVN) wrote:
Author: evalica Date: 2010-12-28 13:22:42 +0100 (Tue, 28 Dec 2010) New Revision: 33714
Modified:
enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeClass.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeTemplate.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/DefaultColorTheme.xml
enterprise/trunk/wiki/src/main/resources/ColorThemes/WizardPropertyMapping.xml
Log: XE-796: Customizable "Add" menu entry from the Color Theme Wizard
Modified: enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml =================================================================== --- enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml 2010-12-28 12:18:23 UTC (rev 33713) +++ enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml 2010-12-28 12:22:42 UTC (rev 33714) @@ -1431,6 +1434,7 @@ <div #elementMetaData('mainmenu')> <div> $msg.get('xe.themes.colors.wizard.mainMenu')
I think it would be better to use a different text for this one, since it's supposed to be used only for the Add entry:
+<span #elementMetaData('menuaddentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#$msg.get('core.menu.create')</span> <span #elementMetaData('menuentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#1</span> <span #elementMetaData('menuentry')>$msg.get('xe.themes.colors.wizard.menuEntry')#2</span> </div>
I kind of like it like this and is consistent, making a clear separation between what is entry or not "Main Menu Entry#Add Entry#1 Entry#2" see http://jira.xwiki.org/jira/secure/attachment/18333/AddCustomization.png
Thanks, Caty
OK, your call. -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Ecaterina Moraru (Valica) -
Sergiu Dumitriu