[xwiki-devs] 3.5.1 release is partly busted...
Hi devs, The RM for 3.5.1 (Sergiu?) made a mistake while releasing and "forgot" some profiles. One consequence is that rendering-standalone hasn't been released in version 3.5.1: - See http://maven.xwiki.org/releases/org/xwiki/rendering/xwiki-rendering-standalo... you'll see that 3.5.1 is missing - Checkout tag 3.5.1 on rendering and view rendering-standalone/pom.xml, you'll see it has <version>3.5-SNAPSHOT</version> has parent version… As a consequence I cannot push Rendering 3.5.1 on Maven Central. Can the RM fix this please? Thanks -Vincent
On 06/12/2012 07:08 AM, Vincent Massol wrote:
Hi devs,
The RM for 3.5.1 (Sergiu?) made a mistake while releasing and "forgot" some profiles.
One consequence is that rendering-standalone hasn't been released in version 3.5.1: - See http://maven.xwiki.org/releases/org/xwiki/rendering/xwiki-rendering-standalo... you'll see that 3.5.1 is missing - Checkout tag 3.5.1 on rendering and view rendering-standalone/pom.xml, you'll see it has <version>3.5-SNAPSHOT</version> has parent version…
As a consequence I cannot push Rendering 3.5.1 on Maven Central.
Can the RM fix this please?
Yes, but I'd rather do a 3.5.2 instead. Re-releasing is not a very good move. The problem is that the RM for the next version (Thomas?) changed the release script replacing the old ci profile with the new legacy and integration-tests, and I noticed that halfway during the release. IIRC, I re-released starting from platform, I forgot that rendering also has a ci-only module. -- Sergiu Dumitriu http://purl.org/net/sergiu/
On Jun 12, 2012, at 4:19 PM, Sergiu Dumitriu wrote:
On 06/12/2012 07:08 AM, Vincent Massol wrote:
Hi devs,
The RM for 3.5.1 (Sergiu?) made a mistake while releasing and "forgot" some profiles.
One consequence is that rendering-standalone hasn't been released in version 3.5.1: - See http://maven.xwiki.org/releases/org/xwiki/rendering/xwiki-rendering-standalo... you'll see that 3.5.1 is missing - Checkout tag 3.5.1 on rendering and view rendering-standalone/pom.xml, you'll see it has <version>3.5-SNAPSHOT</version> has parent version…
As a consequence I cannot push Rendering 3.5.1 on Maven Central.
Can the RM fix this please?
Yes, but I'd rather do a 3.5.2 instead. Re-releasing is not a very good move.
Well rendering standalone has not been released so we could just release that one. However we would need to modify the github tag since right now tag 3.5.1 doesn't build correctly. Thanks -Vincent
The problem is that the RM for the next version (Thomas?) changed the release script replacing the old ci profile with the new legacy and integration-tests, and I noticed that halfway during the release. IIRC, I re-released starting from platform, I forgot that rendering also has a ci-only module. -- Sergiu Dumitriu http://purl.org/net/sergiu/
On 06/12/2012 10:24 AM, Vincent Massol wrote:
On Jun 12, 2012, at 4:19 PM, Sergiu Dumitriu wrote:
On 06/12/2012 07:08 AM, Vincent Massol wrote:
Hi devs,
The RM for 3.5.1 (Sergiu?) made a mistake while releasing and "forgot" some profiles.
One consequence is that rendering-standalone hasn't been released in version 3.5.1: - See http://maven.xwiki.org/releases/org/xwiki/rendering/xwiki-rendering-standalo... you'll see that 3.5.1 is missing - Checkout tag 3.5.1 on rendering and view rendering-standalone/pom.xml, you'll see it has <version>3.5-SNAPSHOT</version> has parent version…
As a consequence I cannot push Rendering 3.5.1 on Maven Central.
Can the RM fix this please?
Yes, but I'd rather do a 3.5.2 instead. Re-releasing is not a very good move.
Well rendering standalone has not been released so we could just release that one. However we would need to modify the github tag since right now tag 3.5.1 doesn't build correctly.
Yes, one of: 1. manual build and mvn deploy of the standalone module 2. full re-release of the xwiki-rendering repository I'm in favor of 1, since it's better not to overwrite existing released files, plus the checksums will change if we do 2. Re-tagging is frowned upon in the git world, it says so in the man page. I wouldn't say that 3.5.1 doesn't build, since it will build correctly if the right profile is activated.
Thanks -Vincent
The problem is that the RM for the next version (Thomas?) changed the release script replacing the old ci profile with the new legacy and integration-tests, and I noticed that halfway during the release. IIRC, I re-released starting from platform, I forgot that rendering also has a ci-only module.
-- Sergiu Dumitriu http://purl.org/net/sergiu/
On Jun 12, 2012, at 4:44 PM, Sergiu Dumitriu wrote:
On 06/12/2012 10:24 AM, Vincent Massol wrote:
On Jun 12, 2012, at 4:19 PM, Sergiu Dumitriu wrote:
On 06/12/2012 07:08 AM, Vincent Massol wrote:
Hi devs,
The RM for 3.5.1 (Sergiu?) made a mistake while releasing and "forgot" some profiles.
One consequence is that rendering-standalone hasn't been released in version 3.5.1: - See http://maven.xwiki.org/releases/org/xwiki/rendering/xwiki-rendering-standalo... you'll see that 3.5.1 is missing - Checkout tag 3.5.1 on rendering and view rendering-standalone/pom.xml, you'll see it has <version>3.5-SNAPSHOT</version> has parent version…
As a consequence I cannot push Rendering 3.5.1 on Maven Central.
Can the RM fix this please?
Yes, but I'd rather do a 3.5.2 instead. Re-releasing is not a very good move.
Well rendering standalone has not been released so we could just release that one. However we would need to modify the github tag since right now tag 3.5.1 doesn't build correctly.
Yes, one of: 1. manual build and mvn deploy of the standalone module 2. full re-release of the xwiki-rendering repository
I'm in favor of 1, since it's better not to overwrite existing released files, plus the checksums will change if we do 2.
Re-tagging is frowned upon in the git world, it says so in the man page.
I wouldn't say that 3.5.1 doesn't build, since it will build correctly if the right profile is activated.
Yes of course, I meant rendering-standalone doesn't build no matter what profile you use. Now the problem is that the standalone JAR is important to be on Maven Central and right now I push stuff to maven central by building the tag so ATM I can't push rendering-standalone to Central. What I can do though it to cheat and edit the pom.xml of rendering-standalone to replace 3.5-SNAPSHOT with 3.5.1 and deploy that to Central. WDYT? Thanks -Vincent
Thanks -Vincent
The problem is that the RM for the next version (Thomas?) changed the release script replacing the old ci profile with the new legacy and integration-tests, and I noticed that halfway during the release. IIRC, I re-released starting from platform, I forgot that rendering also has a ci-only module.
On 06/12/2012 10:48 AM, Vincent Massol wrote:
On Jun 12, 2012, at 4:44 PM, Sergiu Dumitriu wrote:
On 06/12/2012 10:24 AM, Vincent Massol wrote:
On Jun 12, 2012, at 4:19 PM, Sergiu Dumitriu wrote:
On 06/12/2012 07:08 AM, Vincent Massol wrote:
Hi devs,
The RM for 3.5.1 (Sergiu?) made a mistake while releasing and "forgot" some profiles.
One consequence is that rendering-standalone hasn't been released in version 3.5.1: - See http://maven.xwiki.org/releases/org/xwiki/rendering/xwiki-rendering-standalo... you'll see that 3.5.1 is missing - Checkout tag 3.5.1 on rendering and view rendering-standalone/pom.xml, you'll see it has <version>3.5-SNAPSHOT</version> has parent version…
As a consequence I cannot push Rendering 3.5.1 on Maven Central.
Can the RM fix this please?
Yes, but I'd rather do a 3.5.2 instead. Re-releasing is not a very good move.
Well rendering standalone has not been released so we could just release that one. However we would need to modify the github tag since right now tag 3.5.1 doesn't build correctly.
Yes, one of: 1. manual build and mvn deploy of the standalone module 2. full re-release of the xwiki-rendering repository
I'm in favor of 1, since it's better not to overwrite existing released files, plus the checksums will change if we do 2.
Re-tagging is frowned upon in the git world, it says so in the man page.
I wouldn't say that 3.5.1 doesn't build, since it will build correctly if the right profile is activated.
Yes of course, I meant rendering-standalone doesn't build no matter what profile you use.
Now the problem is that the standalone JAR is important to be on Maven Central and right now I push stuff to maven central by building the tag so ATM I can't push rendering-standalone to Central. What I can do though it to cheat and edit the pom.xml of rendering-standalone to replace 3.5-SNAPSHOT with 3.5.1 and deploy that to Central.
Ah, I see now, the pom has the wrong version in it since the release:prepare didn't include it in the list of modules to release. Indeed, that's pretty broken. Yes, I'd go for your "cheat" as well.
WDYT?
Thanks -Vincent
Thanks -Vincent
The problem is that the RM for the next version (Thomas?) changed the release script replacing the old ci profile with the new legacy and integration-tests, and I noticed that halfway during the release. IIRC, I re-released starting from platform, I forgot that rendering also has a ci-only module.
-- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Sergiu Dumitriu -
Vincent Massol