[xwiki-devs] [VOTE] Move xwiki-core-rest to trunk
Dear all, I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1. It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included. Here it is my +1 -Fabio
+1 Fabio Mancinelli wrote:
Dear all,
I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1.
It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included.
Here it is my +1
-Fabio _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Jan 8, 2009, at 12:44 AM, Fabio Mancinelli wrote:
Dear all,
I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1.
It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included.
Do we have tests for it?
Here it is my +1
-Fabio
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
Vincent Massol wrote:
On Jan 8, 2009, at 12:44 AM, Fabio Mancinelli wrote:
Dear all,
I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1.
It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included.
Do we have tests for it?
Yes. http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/src/test/java/org... Actually there is a small thing that needs to be modified in those tests. They are working but they use target URIs from constants in the code while they should retrieve those URIs from the components in components.xml (because they are configurable and variables). So I need to setup a component manager in order to retrieve them. I tried to do something like: ComponentManager componentManager = new PlexusComponentManager(new DefaultPlexusContainer); componentManager.lookup(SpacesResource.class.getName()) But the lookup fails. Maybe I am missing something. -Fabio
On Jan 8, 2009, at 10:35 AM, Fabio Mancinelli wrote:
Vincent Massol wrote:
On Jan 8, 2009, at 12:44 AM, Fabio Mancinelli wrote:
Dear all,
I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1.
It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included.
Do we have tests for it?
Yes. http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/src/test/java/org...
These are unit tests right? I think we'll need a few integration ones too to ensure the whole thing works. These selenium tests can be put in the enterprise/ project under distribution-tests/selenium-tests IMO.
Actually there is a small thing that needs to be modified in those tests. They are working but they use target URIs from constants in the code while they should retrieve those URIs from the components in components.xml (because they are configurable and variables).
So I need to setup a component manager in order to retrieve them. I tried to do something like:
ComponentManager componentManager = new PlexusComponentManager(new DefaultPlexusContainer); componentManager.lookup(SpacesResource.class.getName())
But the lookup fails. Maybe I am missing something.
You need to use the shared tests in tools for testing components. -Vincent
Vincent Massol wrote:
Yes. http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/src/test/java/org...
These are unit tests right?
I think we'll need a few integration ones too to ensure the whole thing works. These selenium tests can be put in the enterprise/ project under distribution-tests/selenium-tests IMO.
No, they will be moved in the integration tests, as for XMLRPC. They use an HTTP client in order to test that requests are correctly served.
You need to use the shared tests in tools for testing components.
Ok. -Fabio
On Jan 8, 2009, at 11:02 AM, Fabio Mancinelli wrote:
Vincent Massol wrote:
Yes. http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/src/test/java/org...
These are unit tests right?
I think we'll need a few integration ones too to ensure the whole thing works. These selenium tests can be put in the enterprise/ project under distribution-tests/selenium-tests IMO.
No, they will be moved in the integration tests, as for XMLRPC. They use an HTTP client in order to test that requests are correctly served.
Are you saying that tests in http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/src/test/java/org... are all integration tests? If so how can they run since there's no running XE?
You need to use the shared tests in tools for testing components.
Ok.
That's for unit tests of course. Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
Vincent Massol wrote:
Are you saying that tests in http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/src/test/java/org... are all integration tests? If so how can they run since there's no running XE?
Infact they can't. I just put them there for convenience. I wrote a README.txt to say that. Finally there are no unit tests in this module. -Fabio
Fabio Mancinelli wrote:
Dear all,
I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1.
It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included.
Any other feedback about this? -Fabio
On Jan 9, 2009, at 7:43 PM, Fabio Mancinelli wrote:
Fabio Mancinelli wrote:
Dear all,
I've finished to refactor the rest subsystem and I propose to move it to the trunk for inclusion in 1.8M1.
It doesn't support all the URIs of the API (see http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI for details) but still I think it's good to have it included.
Any other feedback about this?
Will the tests be moved and working in your move proposal? If yes then I'm +1 Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
Vincent Massol wrote:
On Jan 9, 2009, at 7:43 PM, Fabio Mancinelli wrote:
Will the tests be moved and working in your move proposal? If yes then I'm +1
Yes. I plan to move the tests to enterprise/trunk/distribution-test/rest-tests (or another location if you have alternative propositions). -Fabio
Fabio Mancinelli wrote:
Vincent Massol wrote:
On Jan 9, 2009, at 7:43 PM, Fabio Mancinelli wrote:
Will the tests be moved and working in your move proposal? If yes then I'm +1
Yes. I plan to move the tests to enterprise/trunk/distribution-test/rest-tests (or another location if you have alternative propositions).
I am ready for the integration, but so far only two +1s are available. The locations for the move are: * /platform/core/xwiki-rest (For the main code) * /enterprise/distribution-tests/rest-tests (For the integration tests). I have tested everything and it's working locally, so as soon as there are enough votes I will be able to svn commit immediately. -Thanks Fabio
+1. JV. On Sat, Jan 10, 2009 at 9:10 PM, Fabio Mancinelli <[email protected]> wrote:
Fabio Mancinelli wrote:
Vincent Massol wrote:
On Jan 9, 2009, at 7:43 PM, Fabio Mancinelli wrote:
Will the tests be moved and working in your move proposal? If yes then I'm +1
Yes. I plan to move the tests to enterprise/trunk/distribution-test/rest-tests (or another location if you have alternative propositions).
I am ready for the integration, but so far only two +1s are available.
The locations for the move are:
* /platform/core/xwiki-rest (For the main code) * /enterprise/distribution-tests/rest-tests (For the integration tests).
I have tested everything and it's working locally, so as soon as there are enough votes I will be able to svn commit immediately.
-Thanks Fabio _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (4)
-
Fabio Mancinelli -
Jean-Vincent Drean -
Marius Dumitru Florea -
Vincent Massol