On May 2, 2011, at 10:02 AM, Thomas Mortagne wrote:

On Mon, May 2, 2011 at 09:51, Vincent Massol <[email protected]> wrote:

...

Hi devs,

I have a small issues with the comments on github: they are invisible to the xwiki dev team right now. We used to comment on commit mail diffs which made the comments available to everyone (including non developers) following the notifications/devs lists. Right now we have started using github for commenting but this means I don't see anymore when stuff get commented. I have to go to github specifically and look out for comments.

Actually I'm not sure why you don't but I do receive mail for each comment done on XWiki github. But it's not sent to notification mail indeed.

Ok just found the reason: my gmail account consider them all as spam by default! I've told gmail they are not spam, let's hope it'll not consider the next ones as spam... I'll need to monitor this. Yes, maybe a fake user sending to the list would be good. I agree that the github UI is nicer for commenting I also think that having to click on the link prevents some casual review since it's more effort but it's probably ok. In the future there'll probably be integrations in IDEs as well which can help too for developers. Thanks -Vincent

...

Is there a better way combining our lists + github to keep the open collaboration aspect of reviews?

Thanks -Vincent

On Mon, May 2, 2011 at 10:06, Sergiu Dumitriu <[email protected]> wrote:

On 05/02/2011 09:51 AM, Vincent Massol wrote:

...

Hi devs,

I have a small issues with the comments on github: they are invisible to the xwiki dev team right now. We used to comment on commit mail diffs which made the comments available to everyone (including non developers) following the notifications/devs lists. Right now we have started using github for commenting but this means I don't see anymore when stuff get commented. I have to go to github specifically and look out for comments.

Is there a better way combining our lists + github to keep the open collaboration aspect of reviews?

I receive mails for new comments. Maybe it's some setting in your profile?

We could add a fake user to the list of project members, registered with [email protected], who will receive notifications for new comments.

I do like having comments in the mailbox, but I prefer the UI offered by github. After a few replies, comments in mails become hard to read.

Same for me, I really need to know when a comment is done but I prefer doing and reading them in context on github than in mail as we used to which was pretty hard IMO.

-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne