Vincent Massol wrote:
Hi,
In order to implement
http://jira.xwiki.org/jira/browse/
XTSHAREDTESTS-12 I need to solve a cyclic dependency it creates:
org.xwiki.platform:xwiki-core-url -->
com.xpn.xwiki.platform.tools:xwiki-shared-tests -->
org.xwiki.platform:xwiki-core-container-api -->
org.xwiki.platform:xwiki-core-url
I don't see a good solution other than spliting xwiki-core-url into 2
modules (in order to solve the cyclic dep)
assumptions:
- we need Container in shared tests as otherwise it's going to be a
pain for all tests
- using reflection in shared tests would mean making sure to have deps
on container api in all tests modules
- modifying url module to not use shared tests is a bit of a pain and
not right IMO
- moving XWikiURL to Container API doens't seem right either-
- removing Request.getURL() is not right either and it's used in xwiki-
action anyway
It could be a good idea anyway to separate all modules into 2: api +
implementation. However for practical reasons I don't think we'll do
that, it's too much of a pain and will result in too many jars.
So it's a bit strange to do it for xwiki-url and not for others but
again I don't see solutions right now....
If nobody shouts I'd like to commit the url module split quickly
(since I have it done and it's blocking me on some other issue).
+1
I think it is a good idea to extract the URL API anyway, since in the
future we could have different URL mappings. A nice idea would be to
have different mappings for each wiki, selectable in the wiki admin UI.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/