[xwiki-devs] [Proposal] Enable space rights inheritance as default setting
Dear devs, Since XWiki 1.2, a rights inheritance mechanism is available in XWiki that allows to make a wiki space have the exact same rights (inherited) as it's parent space, defined as a WebPreferences ("parent" property of the XWiki.XWikiPreferences object). This mechanism has to be activated adding "xwiki.rights.maxrecursivespacechecks=1" to xwiki.cfg I propose we enable this as a default setting. This is very usefull when developing applications in XWiki for example (example: to have MyAppCode inherit XWiki). I see two ways of doing it : 1) We make "1" being default returned value in the java code when the property is not defined in xwiki.cfg, and document the use of xwiki.rights.maxrecursivespacechecks to disable the mechanism, or to allow more levels of inheritance (2, 3, etc.) 2) We add xwiki.rights.maxrecursivespacechecks=1 to xwiki.cfg I prefer way 1) and am +1 for it WDYT ? Regards, Jerome.
+1 for 1) But why =1? Is it sufficient for all? If I understand correctly, the purpose of this option is to prevent cycling. So I'd set this option to ~10 and forget of its existence. :) Is any drawbacks of this? Jerome Velociter wrote:
Dear devs,
Since XWiki 1.2, a rights inheritance mechanism is available in XWiki that allows to make a wiki space have the exact same rights (inherited) as it's parent space, defined as a WebPreferences ("parent" property of the XWiki.XWikiPreferences object). This mechanism has to be activated adding "xwiki.rights.maxrecursivespacechecks=1" to xwiki.cfg
I propose we enable this as a default setting. This is very usefull when developing applications in XWiki for example (example: to have MyAppCode inherit XWiki).
I see two ways of doing it :
1) We make "1" being default returned value in the java code when the property is not defined in xwiki.cfg, and document the use of xwiki.rights.maxrecursivespacechecks to disable the mechanism, or to allow more levels of inheritance (2, 3, etc.) 2) We add xwiki.rights.maxrecursivespacechecks=1 to xwiki.cfg
I prefer way 1) and am +1 for it
WDYT ?
-- Artem Melentyev
Agreed with Artem, it should be more than 1 by default. On Mon, Sep 1, 2008 at 2:19 PM, Artem Melentyev <[email protected]> wrote:
+1 for 1)
But why =1? Is it sufficient for all? If I understand correctly, the purpose of this option is to prevent cycling. So I'd set this option to ~10 and forget of its existence. :) Is any drawbacks of this?
Jerome Velociter wrote:
Dear devs,
Since XWiki 1.2, a rights inheritance mechanism is available in XWiki that allows to make a wiki space have the exact same rights (inherited) as it's parent space, defined as a WebPreferences ("parent" property of the XWiki.XWikiPreferences object). This mechanism has to be activated adding "xwiki.rights.maxrecursivespacechecks=1" to xwiki.cfg
I propose we enable this as a default setting. This is very usefull when developing applications in XWiki for example (example: to have MyAppCode inherit XWiki).
I see two ways of doing it :
1) We make "1" being default returned value in the java code when the property is not defined in xwiki.cfg, and document the use of xwiki.rights.maxrecursivespacechecks to disable the mechanism, or to allow more levels of inheritance (2, 3, etc.) 2) We add xwiki.rights.maxrecursivespacechecks=1 to xwiki.cfg
I prefer way 1) and am +1 for it
WDYT ?
-- Artem Melentyev _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 Thomas Mortagne wrote:
Agreed with Artem, it should be more than 1 by default.
On Mon, Sep 1, 2008 at 2:19 PM, Artem Melentyev <[email protected]> wrote:
+1 for 1)
But why =1? Is it sufficient for all? If I understand correctly, the purpose of this option is to prevent cycling. So I'd set this option to ~10 and forget of its existence. :) Is any drawbacks of this?
Jerome Velociter wrote:
Dear devs,
Since XWiki 1.2, a rights inheritance mechanism is available in XWiki that allows to make a wiki space have the exact same rights (inherited) as it's parent space, defined as a WebPreferences ("parent" property of the XWiki.XWikiPreferences object). This mechanism has to be activated adding "xwiki.rights.maxrecursivespacechecks=1" to xwiki.cfg
I propose we enable this as a default setting. This is very usefull when developing applications in XWiki for example (example: to have MyAppCode inherit XWiki).
I see two ways of doing it :
1) We make "1" being default returned value in the java code when the property is not defined in xwiki.cfg, and document the use of xwiki.rights.maxrecursivespacechecks to disable the mechanism, or to allow more levels of inheritance (2, 3, etc.) 2) We add xwiki.rights.maxrecursivespacechecks=1 to xwiki.cfg
I prefer way 1) and am +1 for it
-- Sergiu Dumitriu http://purl.org/net/sergiu/
Well there is also speed enhancement when the option is set to the minimum level. The system has to check more rights the more levels there is Ludovic Artem Melentyev wrote:
+1 for 1)
But why =1? Is it sufficient for all? If I understand correctly, the purpose of this option is to prevent cycling. So I'd set this option to ~10 and forget of its existence. :) Is any drawbacks of this?
Jerome Velociter wrote:
Dear devs,
Since XWiki 1.2, a rights inheritance mechanism is available in XWiki that allows to make a wiki space have the exact same rights (inherited) as it's parent space, defined as a WebPreferences ("parent" property of the XWiki.XWikiPreferences object). This mechanism has to be activated adding "xwiki.rights.maxrecursivespacechecks=1" to xwiki.cfg
I propose we enable this as a default setting. This is very usefull when developing applications in XWiki for example (example: to have MyAppCode inherit XWiki).
I see two ways of doing it :
1) We make "1" being default returned value in the java code when the property is not defined in xwiki.cfg, and document the use of xwiki.rights.maxrecursivespacechecks to disable the mechanism, or to allow more levels of inheritance (2, 3, etc.) 2) We add xwiki.rights.maxrecursivespacechecks=1 to xwiki.cfg
I prefer way 1) and am +1 for it
WDYT ?
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
Yes. + Use cases where we would need more than one level are pretty rare IMHO. (I think we never needed that so far) Jerome. Ludovic Dubost wrote:
Well there is also speed enhancement when the option is set to the minimum level. The system has to check more rights the more levels there is
Ludovic
Artem Melentyev wrote:
+1 for 1)
But why =1? Is it sufficient for all? If I understand correctly, the purpose of this option is to prevent cycling. So I'd set this option to ~10 and forget of its existence. :) Is any drawbacks of this?
Jerome Velociter wrote:
Dear devs,
Since XWiki 1.2, a rights inheritance mechanism is available in XWiki that allows to make a wiki space have the exact same rights (inherited) as it's parent space, defined as a WebPreferences ("parent" property of the XWiki.XWikiPreferences object). This mechanism has to be activated adding "xwiki.rights.maxrecursivespacechecks=1" to xwiki.cfg
I propose we enable this as a default setting. This is very usefull when developing applications in XWiki for example (example: to have MyAppCode inherit XWiki).
I see two ways of doing it :
1) We make "1" being default returned value in the java code when the property is not defined in xwiki.cfg, and document the use of xwiki.rights.maxrecursivespacechecks to disable the mechanism, or to allow more levels of inheritance (2, 3, etc.) 2) We add xwiki.rights.maxrecursivespacechecks=1 to xwiki.cfg
I prefer way 1) and am +1 for it
WDYT ?
Ludovic Dubost wrote:
Well there is also speed enhancement when the option is set to the minimum level. The system has to check more rights the more levels there is
But there is only if user set too many inheritance. Also if he sets so, he may be confused what it not work, if max=1. Why we should restrict users? -- Artem Melentyev
Artem Melentyev wrote:
Ludovic Dubost wrote:
Well there is also speed enhancement when the option is set to the minimum level. The system has to check more rights the more levels there is
But there is only if user set too many inheritance. It costs at least the call to check there is not more inheritance Also if he sets so, he may be confused what it not work, if max=1. Why we should restrict users?
participants (5)
-
Artem Melentyev -
Jerome Velociter -
Ludovic Dubost -
Sergiu Dumitriu -
Thomas Mortagne