[xwiki-devs] [proposal] Deprecate functions in XWikiAttachment and XWikiAttachmentArchive which are bound to JRCS based implementation.
I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content. I didn't find these functions used anywhere else in platform. These are the functions I would like to deprecate: XWikiAttachment public void setArchive(Archive archive) public Archive getArchive() XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive) WDYT? Caleb
+0 Thanks, Marius On 10/11/2010 09:56 AM, Caleb James DeLisle wrote:
I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content.
I didn't find these functions used anywhere else in platform.
These are the functions I would like to deprecate:
XWikiAttachment public void setArchive(Archive archive) public Archive getArchive()
XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive)
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+0 On Mon, Oct 11, 2010 at 08:56, Caleb James DeLisle <[email protected]> wrote:
I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content.
I didn't find these functions used anywhere else in platform.
These are the functions I would like to deprecate:
XWikiAttachment public void setArchive(Archive archive) public Archive getArchive()
XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive)
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-0 this is too late for 2.5 IMO. I'm +0 to do this in 2.6M1. I don't think this is critical for the 2.6 release. Thanks -Vincent On Oct 11, 2010, at 8:56 AM, Caleb James DeLisle wrote:
I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content.
I didn't find these functions used anywhere else in platform.
These are the functions I would like to deprecate:
XWikiAttachment public void setArchive(Archive archive) public Archive getArchive()
XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive)
WDYT?
Caleb
On 10/11/2010 08:56 AM, Caleb James DeLisle wrote:
I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content.
I didn't find these functions used anywhere else in platform.
These are the functions I would like to deprecate:
XWikiAttachment public void setArchive(Archive archive) public Archive getArchive()
XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive)
WDYT?
+1 for the deprecation, but for 2.6M1, not for 2.5. Note that this is not critical since it's not part of the public API, so it's not that visible. -- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 Denis On Mon, Oct 11, 2010 at 22:27, Sergiu Dumitriu <[email protected]> wrote:
On 10/11/2010 08:56 AM, Caleb James DeLisle wrote:
I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content.
I didn't find these functions used anywhere else in platform.
These are the functions I would like to deprecate:
XWikiAttachment public void setArchive(Archive archive) public Archive getArchive()
XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive)
WDYT?
+1 for the deprecation, but for 2.6M1, not for 2.5.
Note that this is not critical since it's not part of the public API, so it's not that visible.
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
participants (6)
-
Caleb James DeLisle -
Denis Gervalle -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol