[xwiki-devs] [vote] Move MacroDescriptorTranslator from the wysiwyg server module to the rendering module
Hi devs, in order to be able to translate the macro descriptors to use for the gadgets (for the moment, to be able to provide the title of the gadget), I would like to move the MacroDescriptorTranslator and its implementation from the wysiwyg gwt module to the rendering module. My +1 on this. We'd also have to refactor it to use the org.xwiki.rendering.macro.descriptor.MacroDescriptor instead of the gwt, serializable clone of it. About where in the rendering to put it, we could either: 1/ create a new module for it, under xwiki-core-rendering 2/ put it in xwiki-core-rendering-api since it's about translating macro descriptors which have both the interface and implementation in the api module 3/ create a new module for it under xwiki-core-rendering-macros My +1 for 2/ WDYT?
On Wed, Dec 22, 2010 at 18:33, Anca Luca <[email protected]> wrote:
Hi devs,
in order to be able to translate the macro descriptors to use for the gadgets (for the moment, to be able to provide the title of the gadget), I would like to move the MacroDescriptorTranslator and its implementation from the wysiwyg gwt module to the rendering module.
My +1 on this.
-0 This tool is supposed to be temporary waiting for new translation module to be finished and support variables.
We'd also have to refactor it to use the org.xwiki.rendering.macro.descriptor.MacroDescriptor instead of the gwt, serializable clone of it.
About where in the rendering to put it, we could either: 1/ create a new module for it, under xwiki-core-rendering 2/ put it in xwiki-core-rendering-api since it's about translating macro descriptors which have both the interface and implementation in the api module
No rendering-api does not contain anything about macros anymore, APIs included, If there is anything left that's a bug
3/ create a new module for it under xwiki-core-rendering-macros
-1, this is supposed to contains macros
My +1 for 2/
WDYT?
I would prefer we wait for new translation module.
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On 12/22/2010 07:59 PM, Thomas Mortagne wrote:
On Wed, Dec 22, 2010 at 18:33, Anca Luca<[email protected]> wrote:
Hi devs,
in order to be able to translate the macro descriptors to use for the gadgets (for the moment, to be able to provide the title of the gadget), I would like to move the MacroDescriptorTranslator and its implementation from the wysiwyg gwt module to the rendering module.
My +1 on this.
-0
This tool is supposed to be temporary waiting for new translation module to be finished and support variables.
I see. But until then, it's achieving a general purpose, not a wysiwyg gwt-specific one, and I will do it if I _really_ need it before the new localization module is done. Not doing it will mean either: a/ having non-translated gadget titles on the Main.Dashboard (regardless the language, the title will still be in English because it's the name of the macro) b/ making xwiki-core-rendering-macros-dashboard depend on the xwiki-web-gwt-wysiwyg-server.
We'd also have to refactor it to use the org.xwiki.rendering.macro.descriptor.MacroDescriptor instead of the gwt, serializable clone of it.
About where in the rendering to put it, we could either: 1/ create a new module for it, under xwiki-core-rendering 2/ put it in xwiki-core-rendering-api since it's about translating macro descriptors which have both the interface and implementation in the api module
No rendering-api does not contain anything about macros anymore, APIs included, If there is anything left that's a bug
True. To follow my idea of having it next to the MacroDescriptor definition and API, let me change that to 2/ put it in xwiki-core-rendering-transformation-macro
3/ create a new module for it under xwiki-core-rendering-macros
-1, this is supposed to contains macros
4/ create a new module in xwiki-core and put it there.
My +1 for 2/
WDYT?
I would prefer we wait for new translation module.
I found this http://extensions.xwiki.org/xwiki/bin/view/Extension/Localization+Module about the localization module, but do we have an ETA for it being ready to be used or a plan about this? Thanks, Anca
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Anca Luca -
Thomas Mortagne