Why is PluginApi#getPlugin public?
Hello, AFAIK, XWiki APIs should be public wrappers around a hidden full-fledged java object, which can only be accessed directly by PR users. Certainly, this is not the case with plugins, which return the inner Plugin object without any check. I'd propose to change this method, so that it behaves as all the other API classes, and checks for programming rights before returning this object. Is there any reason why this change shouldn't be performed? Sergiu -- http://purl.org/net/sergiu
On Jun 29, 2007, at 12:17 AM, Sergiu Dumitriu wrote:
Hello,
AFAIK, XWiki APIs should be public wrappers around a hidden full-fledged java object, which can only be accessed directly by PR users. Certainly, this is not the case with plugins, which return the inner Plugin object without any check.
I'd propose to change this method, so that it behaves as all the other API classes, and checks for programming rights before returning this object. Is there any reason why this change shouldn't be performed?
+1 to make the change. Thanks -Vincent
participants (2)
-
Sergiu Dumitriu -
Vincent Massol