I have look quickly into the changes, and it is no so trivial to fix this legacy code. I agree, there is very little chance that anyone as ever used that legacy API. So, +1 to remove. On Thu, Apr 23, 2015 at 9:22 AM, [email protected] <[email protected]> wrote:

Hi devs,

With the upgrade of BouncyCastle to version 1.52 the xwiki-platform-legacy-crypto-script legacy module doesn’t build anymore since BC has removed deprecated code.

We have of course the option to try to fix the legacy code to use newer APIs.

However I think this is overkill and not needed because I don’t believe this legacy code was ever used (Caleb, the author of it, seems to agree with this).

See the comments at http://jira.xwiki.org/browse/XCOMMONS-794

Thus, according to our rules, I’m sending this VOTE to decide to break this API voluntarily by removing this legacy module.

Here’s my +1

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO

+0 Thanks, Marius On Thu, Apr 23, 2015 at 10:22 AM, [email protected] <[email protected]> wrote:

Hi devs,

With the upgrade of BouncyCastle to version 1.52 the xwiki-platform-legacy-crypto-script legacy module doesn’t build anymore since BC has removed deprecated code.

We have of course the option to try to fix the legacy code to use newer APIs.

However I think this is overkill and not needed because I don’t believe this legacy code was ever used (Caleb, the author of it, seems to agree with this).

See the comments at http://jira.xwiki.org/browse/XCOMMONS-794

Thus, according to our rules, I’m sending this VOTE to decide to break this API voluntarily by removing this legacy module.

Here’s my +1

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

+1, I like to see legacy code gone. On 04/23/2015 03:22 AM, [email protected] wrote:

Hi devs,

With the upgrade of BouncyCastle to version 1.52 the xwiki-platform-legacy-crypto-script legacy module doesn’t build anymore since BC has removed deprecated code.

We have of course the option to try to fix the legacy code to use newer APIs.

However I think this is overkill and not needed because I don’t believe this legacy code was ever used (Caleb, the author of it, seems to agree with this).

See the comments at http://jira.xwiki.org/browse/XCOMMONS-794

Thus, according to our rules, I’m sending this VOTE to decide to break this API voluntarily by removing this legacy module.

Here’s my +1

Thanks -Vincent

-- Sergiu Dumitriu http://purl.org/net/sergiu/