+1 It will be also useful fo other things On Fri, Sep 4, 2009 at 14:06, Vincent Massol<[email protected]> wrote:

Hi,

We currently have a bug with script macros and contexts: http://jira.xwiki.org/jira/browse/XWIKI-4279

I can easily solve it by backuping and restoring the Execution Context in getRenderedContent(String, String, String).

I think this is the correct way since the context should be isolated when rendering IMO.

Now, note that isolating the EC means the velocitycontext will be cloned (shallow cloning though right now). Which means that if some calls to getRenderedContent(String, String, String) save stuff in the velo context for the caller they may fail. I don't know if this happens anywhere in our code but it's unlikely since the calls from vm files are usually calls to getRenderedContent() without parameters which doesn't save/Restore the contexts.

Here's my +1 for isolating the contexts in getRenderedContent(String, String, String) and my +1 to apply this change now for RC1.

Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne

+0 JV. On Fri, Sep 4, 2009 at 2:06 PM, Vincent Massol<[email protected]> wrote:

Hi,

We currently have a bug with script macros and contexts: http://jira.xwiki.org/jira/browse/XWIKI-4279

I can easily solve it by backuping and restoring the Execution Context in getRenderedContent(String, String, String).

I think this is the correct way since the context should be isolated when rendering IMO.

Now, note that isolating the EC means the velocitycontext will be cloned (shallow cloning though right now). Which means that if some calls to getRenderedContent(String, String, String) save stuff in the velo context for the caller they may fail. I don't know if this happens anywhere in our code but it's unlikely since the calls from vm files are usually calls to getRenderedContent() without parameters which doesn't save/Restore the contexts.

Here's my +1 for isolating the contexts in getRenderedContent(String, String, String) and my +1 to apply this change now for RC1.

Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs