xwiki.org says that XWiki uses log4j, but the code uses a mix of both commons logging interfaces, and those particular to log4j.. Should we be picking one? It seems that the commons logging interfaces would be preferred (as it knows how to interact with log4j), but I'm not sure. ? -- Waste of a good apple. --Samwise Gamgee
Hi Erin, On Jul 21, 2007, at 1:44 AM, Erin Schnabel wrote:
xwiki.org says that XWiki uses log4j, but the code uses a mix of both commons logging interfaces, and those particular to log4j.. Should we be picking one? It seems that the commons logging interfaces would be preferred (as it knows how to interact with log4j), but I'm not sure.
Where is it saying that on xwiki.org? On the debugging page? (I have just modified that page to make it more clear). But yes XWiki is using Commons-logging with a configuration for log4J. Commons-logging doesn't much by itself and needs an underlying implementation. In the past months we (Sergiu mostly) have tried to remove all calls to Log4J in the code in favor of commons-logging. I know there are some left in the XWikiAction class for example which uses MDC that should be removed. So yes CL is the target. If you want to send tested patches to fully remove Log4J please do so, that'll help. Thanks -Vincent
Good enough. I have plugins I have to finish for my site (I know you want me to submit patches, but I have a lot of stuff I have to have working yesterday, if you know what I mean).. and as I'm generating code I might want to submit, I wanted to know which logging interface was preferred. So.. ;) On Sat, July 21, 2007 3:17 am, Vincent Massol wrote:
Hi Erin,
On Jul 21, 2007, at 1:44 AM, Erin Schnabel wrote:
xwiki.org says that XWiki uses log4j, but the code uses a mix of both commons logging interfaces, and those particular to log4j.. Should we be picking one? It seems that the commons logging interfaces would be preferred (as it knows how to interact with log4j), but I'm not sure.
Where is it saying that on xwiki.org? On the debugging page? (I have just modified that page to make it more clear).
But yes XWiki is using Commons-logging with a configuration for log4J. Commons-logging doesn't much by itself and needs an underlying implementation.
In the past months we (Sergiu mostly) have tried to remove all calls to Log4J in the code in favor of commons-logging. I know there are some left in the XWikiAction class for example which uses MDC that should be removed.
So yes CL is the target. If you want to send tested patches to fully remove Log4J please do so, that'll help.
Thanks -Vincent
-- Waste of a good apple. --Samwise Gamgee
participants (2)
-
Erin Schnabel -
Vincent Massol