Hi, Venkatesh Nandakumar wrote:

Hi,

For the rest, I'll wait for your first contribution as soon as it's ready.

I have committed the attachment-display code, as I told you yesterday itself. Please do have a look at it.

Should Attachments be cached (LocalXWikiDataStorage)? Or should it be done depending on size(I don't think xmlrpc function exists to check size)?

The xml-rpc attachment has the filesize field. So you'll have all file sizes when you retrieve the attachment lists.

In my opinion, Attachments should not be cached. -0.5 for attachment cache or prefetch. IMHO, this doesn't worth spending time on, unless some users request this feature. I had initially thought of using LocalXWikiDataStorage, and then ran into some problems (At isLocallyAvailable() of DataManager class) because Attachment Class is defined by Confluence, and hence is not that flexible according to our requirements. You can always extend the model. Secondly, Caching a 2-5MB, say, attachment is not feasible. Is there any way around?

What should I do when the user wants to "Open" the attachment from the Navigator?

1) Download & open the attachment with the default assigned application. 2) See if you can open and stream the attachment content directly from its' download url. XWord uses 1) with a user configurable attachment repository. Thanks, Florin Ciubotaru

Venkatesh Nandakumar Department of Electronics & Computer Engineering Indian Institute of Technology Roorkee _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs